Skip to content

Add missing isAntiAlias override to $Container - #141

Closed
yusufkecer wants to merge 1 commit into
ethanblake4:masterfrom
yusufkecer:fix-is-anti-alias
Closed

Add missing isAntiAlias override to $Container#141
yusufkecer wants to merge 1 commit into
ethanblake4:masterfrom
yusufkecer:fix-is-anti-alias

Conversation

@yusufkecer

@yusufkecer yusufkecer commented Aug 13, 2026

Copy link
Copy Markdown

On current Flutter, flutter_eval does not compile at all:

Error: The non-abstract class '$Container' is missing implementations for these members:
 - Container.isAntiAlias
class $Container implements Container, $Instance {
      ^^^^^^^^^^

Container gained an isAntiAlias field and $Container implements Container, so the class is abstract by omission. Any package depending on flutter_eval fails to build, including its own test suite.

This forwards the property the same way the other Container properties are forwarded, next to clipBehavior.

With the fix: flutter analyze lib reports no errors, and all 16 tests in test/flutter_eval_test.dart pass.

Container gained an `isAntiAlias` field, and $Container implements Container
without it, so the class is abstract-by-omission and the package does not
compile against current Flutter:

  Error: The non-abstract class '$Container' is missing implementations for
  these members:
   - Container.isAntiAlias

This forwards it like every other Container property. With it, `lib/` analyses
clean and all 16 tests in flutter_eval_test.dart pass.
@yusufkecer yusufkecer closed this Aug 13, 2026
@yusufkecer
yusufkecer deleted the fix-is-anti-alias branch August 13, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant