Add missing isAntiAlias override to $Container - #141
Closed
yusufkecer wants to merge 1 commit into
Closed
Conversation
Container gained an `isAntiAlias` field, and $Container implements Container without it, so the class is abstract-by-omission and the package does not compile against current Flutter: Error: The non-abstract class '$Container' is missing implementations for these members: - Container.isAntiAlias This forwards it like every other Container property. With it, `lib/` analyses clean and all 16 tests in flutter_eval_test.dart pass.
yusufkecer
force-pushed
the
fix-is-anti-alias
branch
from
August 13, 2026 21:31
50bef56 to
1bdf450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On current Flutter,
flutter_evaldoes not compile at all:Containergained anisAntiAliasfield and$Container implements Container, so the class is abstract by omission. Any package depending on flutter_eval fails to build, including its own test suite.This forwards the property the same way the other
Containerproperties are forwarded, next toclipBehavior.With the fix:
flutter analyze libreports no errors, and all 16 tests intest/flutter_eval_test.dartpass.