Reject existing-user claims in FastAPI signup flow#204
Open
PrivateBasicsApp wants to merge 5 commits into
Open
Reject existing-user claims in FastAPI signup flow#204PrivateBasicsApp wants to merge 5 commits into
PrivateBasicsApp wants to merge 5 commits into
Conversation
Details: - base.txt: Django >=5.2,<6.0, pin fastapi==0.138.2, and raise the redis floor to >=5.0 (drops the 4.2.0rc1 pre-release marker that was keeping the runtime on the redis 5.1.0b6 beta) - development.txt: constrain dev deps to the runtime pins via -c requirements.txt - Regenerate both lockfiles with pip-compile --generate-hashes for reproducible, hash-verified installs Runtime now requires Python >=3.10 (Django 5.2).
+ pyproject.toml: set DJANGO_SETTINGS_MODULE for pytest-django + dev deps: add pytest-django (requirements.in/development.txt + regenerated requirements-dev.txt)
Chore/update dependencies (Django 5.2, FastAPI 0.138 + security)etesync#205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent unauthenticated account takeover where
/signup/could initializeUserInfofor a pre-provisioned user and immediately return a valid auth token.Details:
signup_save(etebase_server/fastapi/routers/authentication.py) check for an existing username viaget_user_queryset(...).get(...)and immediately raiseHttpError("user_exists", ...)(HTTP 409) if found.