Skip to content

adding a Qt 6.11 build so we can make it work #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eteran merged 2 commits into from
Sep 4, 2026
Merged

adding a Qt 6.11 build so we can make it work #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
708d11c
adding a Qt 6.11 build so we can make it work
eteran Sep 4, 2026
8938bd0
more Qt 6.11 patches
eteran Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-24.04
strategy:
matrix:
QT_VERSION: [5.15.*, 6.8.*]
QT_VERSION: [5.15.*, 6.8.*, 6.11.*]
steps:
- name: Install Dependencies
run: sudo apt-get install -y libcapstone-dev libgraphviz-dev
Expand Down
9 changes: 4 additions & 5 deletions src/Debugger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class RunUntilRet : public IDebugEventHandler {
IDebugEvent::TRAP_REASON trap_reason = event->trapReason();
IDebugEvent::REASON reason = event->reason();

qDebug() << QStringLiteral("Event at address 0x%1").arg(address, 0, 16);
qDebug() << QStringLiteral("Event at address 0x%1").arg(address.toPointerString());

/*
* An IDebugEvent::TRAP_BREAKPOINT can happen for the following reasons:
Expand Down Expand Up @@ -251,12 +251,12 @@ class RunUntilRet : public IDebugEventHandler {

// Get the instruction
edb::Instruction inst(buffer, buffer + size, 0);
qDebug() << QStringLiteral("Scanning for terminator at 0x%1: found %2").arg(address, 0, 16).arg(QString::fromStdString(inst.mnemonic()));
qDebug() << QStringLiteral("Scanning for terminator at 0x%1: found %2").arg(address.toPointerString()).arg(QString::fromStdString(inst.mnemonic()));

// Check if it's a proper block terminator (ret/jmp/jcc/hlt)
if (inst) {
if (is_terminator(inst)) {
qDebug() << QStringLiteral("Found terminator %1 at 0x%2").arg(QString::fromStdString(inst.mnemonic())).arg(address, 0, 16);
qDebug() << QStringLiteral("Found terminator %1 at 0x%2").arg(QString::fromStdString(inst.mnemonic())).arg(address.toPointerString());
// If we already had a breakpoint there, then just continue.
if (std::shared_ptr<IBreakpoint> bp = edb::v1::debugger_core->findBreakpoint(address)) {
qDebug() << "Already a breakpoint at terminator: " << address.toHexString();
Expand Down Expand Up @@ -1968,8 +1968,7 @@ void Debugger::mnuDumpSaveToFile() {

if (!filename.isEmpty()) {
QFile file(filename);
file.open(QIODevice::WriteOnly);
if (file.isOpen()) {
if (file.open(QIODevice::WriteOnly)) {
file.write(s->allBytes());
}
}
Expand Down