fix(deps): bump axios to 1.20.0 to clear four advisories - #291
Conversation
Resolves GHSA-mmx7-hfxf-jppx, GHSA-7q8q-rj6j-mhjq, GHSA-42h9-826w-cgv3 and GHSA-pmv8-rq9r-6j72, all fixed in 1.18.0. axios is transitive under mailgun.js 12.0.3, which allows ^1.10.0, so this is a lockfile-only change with no manifest edit and no mailgun.js bump. es-object-atoms, form-data and hasown come along as axios's own dependencies moving within their existing ranges. Dependabot cannot raise this itself: PR #227 proposed the same bump and was closed on 2026-07-27, which registered the release as declined. Regenerated with `npm update axios --package-lock-only` on node 24.14.0 and deliberately WITHOUT --legacy-peer-deps. That flag makes npm ignore peerDependencies, and regenerating the lock with it prunes 10 peer-only vite entries (@vue/compiler-*, @babel/*) and flips 187 devOptional flags -- 409 lines of unrelated churn. See the pull request for why that matters beyond this change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JrPR3vYA5DwEwTiE4E2aJn
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Clears the four open axios advisories, all fixed in 1.18.0:
formDataToJSONcan cause denial of serviceformToJSONkey recursion can cause denial of serviceWhy this is manual
Dependabot cannot raise it. PR #227 proposed the same bump and was closed on 2026-07-27, which registers the release as declined — Dependabot then stops offering that fix, which is why four alerts have sat open with no PR for a month. Reopening #227 is not viable either: that branch is from July, and npm PRs in this repo cannot be rebased (see #290).
Scope
axios is transitive under
mailgun.js@12.0.3, which allows^1.10.0. 1.20.0 satisfies that, so this is lockfile-only — nopackage.jsonedit, and nomailgun.jsbump (14.0.0 is a major and is not needed here).Four entries change, nothing else:
The latter three are axios's own dependencies moving within their existing ranges. Zero entries added, zero removed, zero metadata-only changes.
Verified on node 24.14.0:
tsc --noEmitclean, 473 tests pass across 53 files.One thing worth knowing, beyond this PR
The lock was regenerated without
--legacy-peer-deps, deliberately. That flag makes npm ignorepeerDependenciesentirely, so regenerating the lock with it prunes 10 peer-only vite entries (@vue/compiler-*,@babel/*,entities,estree-walker) and flips 187devOptional→devflags — 409 lines of churn instead of 30.CI runs
npm install --legacy-peer-depsin all five install steps. I reproduced this directly: running that command rewrote this branch's clean lockfile into the 409-line version. Because CI usesnpm installrather thannpm ci, it silently rewrites the lock on every run instead of failing on a mismatch — the difference just never gets committed. Not addressed here; flagging it as a separate issue.🤖 Generated with Claude Code
https://claude.ai/code/session_01JrPR3vYA5DwEwTiE4E2aJn