Guard idle bump against racing metadata webhook#117
Open
errkk wants to merge 1 commit into
Open
Conversation
The IDLE play-state handler evaluated premature_idle? before the settle sleep, against DB state captured before the racing metadata webhook had marked the newly-started track as playing. It then bumped unconditionally after the sleep, marking the just-started track played and removing it from the queue. Re-check after the settle window, before the destructive bump: skip if the player is no longer idle, or if a track has started playing during the window. Only bump + re-trigger when genuinely still idle. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IDLE play-state handler evaluated premature_idle? before the settle sleep, against DB state captured before the racing metadata webhook had marked the newly-started track as playing. It then bumped unconditionally after the sleep, marking the just-started track played and removing it from the queue.
Re-check after the settle window, before the destructive bump: skip if the player is no longer idle, or if a track has started playing during the window. Only bump + re-trigger when genuinely still idle.