Soundcloud runs#116
Merged
Merged
Conversation
Parked investigation surfaced during the SoundCloud spike. Points at set_current_transaction and the suspicious two-pass set_current/1 no-match clause. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Play the queue as single-provider runs. Queue.current_run/0 returns the contiguous same-provider block at the head of the unplayed queue; sync_playlist loads only that run into its provider's playlist and returns the active provider; trigger_playlist matches that provider's Sonos favourite. An all-Spotify queue is one run, so existing behaviour is unchanged. Mixed queues go idle at each boundary and re-trigger the next run. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Records what's deployed/merged/wip, marks the section 0 gates resolved with the discovered object_id shape and API quirks, annotates the order of work, and adds section 12 (setup parity: pick the SoundCloud playlist from a list fetched from the API instead of a hardcoded env var). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
At an idle boundary with tracks remaining, the just-finished run's last track was still marked playing (not played), so Queue.current_run returned the same run again and the provider never switched. Bump it first (as skip does) to make the boundary deterministic instead of depending on an empty-metadata webhook arriving within the 1s window. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Track the actually-playing provider in PlayState, broadcast it, and show a small icon in the header gated behind FF_PROVIDER_SWITCHER or trusted user. Log provider switches and the run-boundary re-trigger flow for inspection. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.