Bump Microsoft.Extensions.Hosting and 8 others - #2301
Conversation
erikdarlingdata
left a comment
There was a problem hiding this comment.
Dependabot group bump: 9 NuGet packages, base is dev ✓. Lock files (~10k lines) look mechanically regenerated. Non-lock changes are Directory.Packages.props and two .csproj files — the .csproj edits are where the interesting things are.
What's good
- Base branch is
dev, notmain. - Central package management is respected in
Directory.Packages.props— one line per bump. - No PlanAnalyzer.cs / schema / install-script / build.yml touches, so the CRITICAL focus items don't apply.
Needs attention (inline comments left on each)
Darling.Analysis.csproj:20— a new<PackageReference Include="ModelContextProtocol" />was added; dependabot doesn't normally introduce new package references. Common.csproj already declares it and flows transitively. Please explain why this is needed or drop it.Darling.Analysis.csproj:21andPlanAnalysis.csproj:25— newVersionOverride="10.0.11"entries forSystem.Security.Cryptography.ProtectedDatathat match the central pin.Directory.Packages.propsexplicitly reservesVersionOverridefor divergence (onlytools/CompactionRepro). These are redundant and re-introduce the misalignment class #2100 was meant to prevent.Directory.Packages.props:15—Microsoft.Extensions.Loggingstays at 10.0.10 while its Hosting / Hosting.WindowsServices / Logging.Abstractions siblings all move to 10.0.11. Same-cadence packages; worth aligning manually so the runtime graph doesn't rely on transitive unification.
Other things worth noting
- Major version bump for xunit (v3
3.2.2→4.0.0; runner3.1.5→4.0.0). Verify the full test suite actually runs — xunit v3→v4 breaking changes tend to hit runners, discovery, and any custom fixture code. - Line-ending noise on the .csproj/props diffs:
+43/-41,+37/-36,+34/-34for what should be a handful of substantive changes each..gitattributessays* text=auto eol=crlf, so dependabot likely wrote LF into files that were CRLF at rest. Nothing broken, but it pollutesgit blamefor those files. Consider normalizing before merge (or a.gitattributesre-normalization pass in a separate commit).
Comments only — no approval / request changes / merge, per the review policy for this repo.
Generated by Claude Code
| <PackageVersion Include="DuckDB.NET.Bindings.Full" Version="1.5.5" /> | ||
| <PackageVersion Include="DuckDB.NET.Data" Version="1.5.5" /> | ||
| <PackageVersion Include="Hardcodet.NotifyIcon.Wpf" Version="2.0.1" /> | ||
| <PackageVersion Include="Microsoft.Data.SqlClient" Version="7.0.2" /> |
There was a problem hiding this comment.
Microsoft.Extensions.Logging is still 10.0.10 while its siblings Microsoft.Extensions.Hosting (line 12), Microsoft.Extensions.Hosting.WindowsServices (line 13), and Microsoft.Extensions.Logging.Abstractions (line 15 → 10.0.11) all moved to 10.0.11. These ship on the same Microsoft.Extensions.* cadence — worth manually bumping so the runtime graph resolves to one aligned patch level instead of NuGet unifying transitively. Microsoft.Extensions.Configuration / Microsoft.Extensions.Configuration.Json at 10.0.10 are the same story if 10.0.11 exists for them.
Generated by Claude Code
| <!-- The plan fetcher connects to the MONITORED SQL Server (same client the Service uses); | ||
| Npgsql and Logging.Abstractions flow transitively from the Storage/Notifications references. --> | ||
| <PackageReference Include="Microsoft.Data.SqlClient" /> | ||
| <PackageReference Include="ModelContextProtocol" /> |
There was a problem hiding this comment.
New <PackageReference Include="ModelContextProtocol" /> here — this project didn't reference MCP before this PR, and a dependabot version bump shouldn't be adding new package references. PerformanceMonitor.Common (line 20 of Common.csproj) already declares it, and Darling.Analysis references Analysis/Collectors which flow through Common, so it should already be available transitively.
If dependabot added this to satisfy a resolution warning, that's a symptom worth chasing (probably a NU1605/NU1608 downgrade) rather than a fix to keep. If it's intentional because Darling.Analysis directly consumes an MCP surface, the comment block just above (which explains what Sql/Npgsql/Logging come from) should say why. Either way I'd drop this line and re-run restore to confirm nothing complains.
Generated by Claude Code
| Npgsql and Logging.Abstractions flow transitively from the Storage/Notifications references. --> | ||
| <PackageReference Include="Microsoft.Data.SqlClient" /> | ||
| <PackageReference Include="ModelContextProtocol" /> | ||
| <PackageReference Include="System.Security.Cryptography.ProtectedData" VersionOverride="10.0.11" /> |
There was a problem hiding this comment.
VersionOverride="10.0.11" here matches the central pin in Directory.Packages.props line 22 (also 10.0.11), so it doesn't diverge — it just duplicates it. The comment at the top of Directory.Packages.props explicitly reserves VersionOverride for divergence ("A project that must diverge pins with VersionOverride at its own reference (only tools/CompactionRepro does…)"). Adding a non-diverging override contradicts that pattern and creates the same misalignment risk #2100 was written to prevent — next time the central version bumps, this line silently pins the old one.
Drop the VersionOverride attribute (or drop the whole line if the reference isn't needed directly; the package flows in transitively through SqlClient / Logging). Same on PlanAnalysis.csproj line 25.
Generated by Claude Code
| XML), so it needs the SqlClient runtime connection surface. Version matches Lite/Dashboard/the Darling | ||
| service (7.0.1) so there is no transitive version skew. --> | ||
| <PackageReference Include="Microsoft.Data.SqlClient" /> | ||
| <PackageReference Include="System.Security.Cryptography.ProtectedData" VersionOverride="10.0.11" /> |
There was a problem hiding this comment.
Same issue as Darling.Analysis.csproj:21 — the VersionOverride="10.0.11" matches the central pin so it's not diverging, and central package management is supposed to be the single source. Also worth noting the comment on line 21 above still says "Version matches Lite/Dashboard/the Darling service (7.0.1)" but the central pin is Microsoft.Data.SqlClient 7.0.2 — a pre-existing stale comment, not this PR's fault, but this is the moment to fix it since you're editing the file.
Generated by Claude Code
Bumps Microsoft.Extensions.Hosting from 10.0.10 to 10.0.11 Bumps Microsoft.Extensions.Hosting.WindowsServices from 10.0.10 to 10.0.11 Bumps Microsoft.Extensions.Logging.Abstractions to 10.0.11 Bumps Microsoft.NET.Test.Sdk from 18.8.1 to 18.9.0 Bumps ModelContextProtocol from 2.1.0 to 2.2.0 Bumps ModelContextProtocol.AspNetCore from 2.1.0 to 2.2.0 Bumps System.Security.Cryptography.ProtectedData to 10.0.11 Bumps xunit.runner.visualstudio from 3.1.5 to 4.0.0 Bumps xunit.v3 from 3.2.2 to 4.0.0 --- updated-dependencies: - dependency-name: Microsoft.Extensions.Hosting dependency-version: 10.0.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget - dependency-name: Microsoft.Extensions.Hosting.WindowsServices dependency-version: 10.0.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget - dependency-name: Microsoft.Extensions.Logging.Abstractions dependency-version: 10.0.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.9.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget - dependency-name: ModelContextProtocol dependency-version: 2.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget - dependency-name: ModelContextProtocol.AspNetCore dependency-version: 2.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget - dependency-name: ModelContextProtocol.AspNetCore dependency-version: 2.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget - dependency-name: System.Security.Cryptography.ProtectedData dependency-version: 10.0.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget - dependency-name: xunit.runner.visualstudio dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget - dependency-name: xunit.v3 dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget ... Signed-off-by: dependabot[bot] <support@github.com>
37dc6f4 to
d11d7f6
Compare
Pinned Microsoft.Extensions.Hosting at 10.0.11.
Release notes
Sourced from Microsoft.Extensions.Hosting's releases.
No release notes found for this version range.
Commits viewable in compare view.
Pinned Microsoft.Extensions.Hosting.WindowsServices at 10.0.11.
Release notes
Sourced from Microsoft.Extensions.Hosting.WindowsServices's releases.
No release notes found for this version range.
Commits viewable in compare view.
Pinned Microsoft.Extensions.Logging.Abstractions at 10.0.11.
Release notes
Sourced from Microsoft.Extensions.Logging.Abstractions's releases.
No release notes found for this version range.
Commits viewable in compare view.
Pinned Microsoft.Extensions.Logging.Abstractions at 10.0.11.
Release notes
Sourced from Microsoft.Extensions.Logging.Abstractions's releases.
No release notes found for this version range.
Commits viewable in compare view.
Updated Microsoft.NET.Test.Sdk from 18.8.1 to 18.9.0.
Release notes
Sourced from Microsoft.NET.Test.Sdk's releases.
18.9.0
What's Changed
New Contributors
Full Changelog: microsoft/vstest@v18.8.0...v18.9.0
Commits viewable in compare view.
Pinned ModelContextProtocol at 2.2.0.
Release notes
Sourced from ModelContextProtocol's releases.
2.2.0
This release adds hybrid stateful/stateless HTTP serving so clients using the 2025-11-25 and 2026-07-28 protocol revisions can share an endpoint, and fixes a malformed header-decoding edge case.
What's Changed
Test Improvements
Repository Infrastructure Updates
Acknowledgements
Full Changelog: modelcontextprotocol/csharp-sdk@v2.1.0...v2.2.0
Commits viewable in compare view.
Pinned ModelContextProtocol.AspNetCore at 2.2.0.
Release notes
Sourced from ModelContextProtocol.AspNetCore's releases.
2.2.0
This release adds hybrid stateful/stateless HTTP serving so clients using the 2025-11-25 and 2026-07-28 protocol revisions can share an endpoint, and fixes a malformed header-decoding edge case.
What's Changed
Test Improvements
Repository Infrastructure Updates
Acknowledgements
Full Changelog: modelcontextprotocol/csharp-sdk@v2.1.0...v2.2.0
Commits viewable in compare view.
Pinned System.Security.Cryptography.ProtectedData at 10.0.11.
Release notes
Sourced from System.Security.Cryptography.ProtectedData's releases.
10.0.0-preview.6.25358.103
You can build .NET 10.0 Preview 6 from the repository by cloning the release tag
v10.0.0-preview.6.25358.103and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
10.0.0-preview.5.25277.114
You can build .NET 10.0 Preview 5 from the repository by cloning the release tag
v10.0.0-preview.5.25277.114and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
10.0.0-preview.4.25258.110
You can build .NET 10.0 Preview 4 from the repository by cloning the release tag
v10.0.0-preview.4.25258.110and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
10.0.0-preview.3.25171.5
You can build .NET 10.0 Preview 3 from the repository by cloning the release tag
v10.0.0-preview.3.25171.5and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
10.0.0-preview.2.25163.2
You can build .NET 10.0 Preview 2 from the repository by cloning the release tag
v10.0.0-preview.2.25163.2and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
10.0.0-preview.1.25080.5
You can build .NET 10.0 Preview 1 from the repository by cloning the release tag
v10.0.0-preview.1.25080.5and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
9.0.120
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.120and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached is a PGP signature for the GitHub generated tarball. You can find the public key at https://dot.net/release-key-2023
9.0.119
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.119and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
9.0.118
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.118and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached is a PGP signature for the GitHub generated tarball. You can find the public key at https://dot.net/release-key-2023
9.0.117
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.117and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
9.0.116
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.116and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
9.0.115
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.115and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
9.0.114
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.114and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached is the PGP signature for the GitHub generated tarball. You can find the public key at https://dot.net/release-key-2023
9.0.113
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.113and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
9.0.112
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.112and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
9.0.111
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.111and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
9.0.110
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.110and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
9.0.109
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.109and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
9.0.101
You can build .NET 9.0 from the repository by cloning the release tag
v9.0.101and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
Commits viewable in compare view.
Updated System.Security.Cryptography.ProtectedData from 10.0.10 to 10.0.11.
Release notes
Sourced from System.Security.Cryptography.ProtectedData's releases.
No release notes found for this version range.
Commits viewable in compare view.
Updated xunit.runner.visualstudio from 3.1.5 to 4.0.0.
Release notes
Sourced from xunit.runner.visualstudio's releases.
4.0.0
Release notes: https://xunit.net/releases/visualstudio/4.0.0
4.0.0-pre.5
Release notes: https://xunit.net/releases/visualstudio/4.0.0-pre.5
4.0.0-pre.4
Release notes: https://xunit.net/releases/visualstudio/4.0.0-pre.4
4.0.0-pre.3
Release notes: https://xunit.net/releases/visualstudio/4.0.0-pre.3
Commits viewable in compare view.
Updated xunit.v3 from 3.2.2 to 4.0.0.
Release notes
Sourced from xunit.v3's releases.
No release notes found for this version range.
Commits viewable in compare view.