feat: add workflow-definition-field-id to SignInFieldAttributes - #121
Merged
mellwood-envoy merged 2 commits intoSep 11, 2026
Merged
Conversation
envoy-web sets this on a sign-in field when a workflow policy owns it and exposes it read-only on the v3 sign-in-fields resource. Consumers that decide whether a field is safe to un-require or delete need to read it, and until now had to widen the type themselves. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
JustWalters
approved these changes
Sep 11, 2026
mellwood-envoy
deleted the
feat/sign-in-field-workflow-definition-field-id
branch
September 11, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds one attribute to
SignInFieldAttributes:envoy-web sets it on a sign-in field when a workflow policy owns that field, and exposes it on the v3
sign-in-fieldsresource asreadonly :workflow_definition_field_idalongsidecreated_atandupdated_at. The column is a nullableuuid, so the value is a string when present andnullotherwise.Why
When a policy is associated to a flow that already carries an integration's sign-in field, envoy-web adopts that field for the policy. From then on the field has two interested parties, and an integration that later un-requires or deletes it on flow removal breaks the policy. The only signal that this has happened is this attribute, and the type gave consumers no way to read it.
envoy-integrations-internal-sdk #242 teaches
EnvoySignInFieldFlowManager.cleanupFlowsto leave such fields alone, but has to widen this interface locally to do it:With this merged and released, that type comes out and
getFieldByIdgoes back to returningSignInFieldModel.Optional and nullable
Optional to match the other attributes and because the server ignores it on create and update, so nothing building an attributes literal needs to supply it. Nullable because a read returns
nullfor every field a policy has not adopted.Verification
prettier --check,tsc --noEmit, and eslint clean. Test suite green: 5 suites, 72 tests. Type-only change, so no new tests.Version bumped to 2.5.4 in
package.jsonandpackage-lock.json, matching how #120 handled the last additive attribute change (2.5.2 -> 2.5.3). Publishing still happens on release creation, so this only stages the version.🤖 Generated with Claude Code