Make the last dotenv file win over the earlier ones - #42
Merged
Conversation
dotenv gives priority to the first file that defines a variable when several paths are passed in one call, so `config: ['.env.commons', '.env']` made `.env.commons` shadow `.env`. Users coming from docker-compose expect the opposite, where entries listed later in `env_file` override the ones before. Reverse the list before handing it to dotenv: the last configured file is parsed first and wins the `override: false` race, while process.env still takes precedence over every file. The existing tests only covered variables defined in a single file each, so the ordering was never exercised. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotenv gives priority to the first file that defines a variable when several paths are passed in one call, so
config: ['.env.commons', '.env']made.env.commonsshadow.env. Users coming from docker-compose expect the opposite, where entries listed later inenv_fileoverride the ones before.Reverse the list before handing it to dotenv: the last configured file is parsed first and wins the
override: falserace, while process.env still takes precedence over every file.The existing tests only covered variables defined in a single file each, so the ordering was never exercised.