Add docker integration tests for parallel resource builds - #39
Merged
Conversation
Prove the scheduler's dependency barrier and the -j/--force flags hold against a real Docker daemon (microservices example, api/worker depend on base:image): - honours the dependency barrier under -j 4 on a CLEAN daemon -- base:image does not exist yet, so api/worker's real `FROM microservices/base` would fail if the scheduler let them start before base finished; a green build proves base was built first, then api and worker concurrently - accepts -j auto - -j 1 builds a dependent chain serially - --force rebuilds under -j Kept in their own spec file (one top-level suite per file, and their own useExampleWithDocker gives a fresh/clean daemon for the barrier test). Also raise the integration-features-docker hookTimeout to 120s: `clean --force` image removal in setup/teardown legitimately exceeds vitest's default 10s hook timeout. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prove the scheduler's dependency barrier and the -j/--force flags hold against a real Docker daemon (microservices example, api/worker depend on base:image):
FROM microservices/basewould fail if the scheduler let them start before base finished; a green build proves base was built first, then api and worker concurrentlyKept in their own spec file (one top-level suite per file, and their own useExampleWithDocker gives a fresh/clean daemon for the barrier test).
Also raise the integration-features-docker hookTimeout to 120s:
clean --forceimage removal in setup/teardown legitimately exceeds vitest's default 10s hook timeout.