Skip to content

fix: close review issues #6-#13 - #14

Closed
enochgroot wants to merge 2 commits into
security/modernize-2.0.0from
fix/review-open-6-13
Closed

enochgroot wants to merge 2 commits into
security/modernize-2.0.0from
fix/review-open-6-13

Conversation

@enochgroot

Copy link
Copy Markdown
Owner

Closes #6 #7 #8 #9 #10 #11 #12 #13

One PR for the eight OPEN review findings on the 2.0 modernization tree.

Changes

Tests

npm test: 135 pass.
JS coverage gate 95% (c8 --check-coverage).
Native coverage: 96.0% lines, 99.5% branches, 100% functions (gcovr --fail-under-line 95 --fail-under-branch 95).

Sabotage: Stream cap tests fail without the allocate check; pack sparse-array test fails without kMaxContainer; CLI tests fail without the stdin cap.

Coverage gate in package.json / COVERAGE.md is unchanged.

Pin nan 2.28.0 and c8 12.0.0; CI uses npm ci.
Raise engines.node to >=22 and drop Node 18/20 from CI.
Pin GitHub Actions to full SHAs.
Cap Stream receive before allocate and drop buf on close.
Apply kMaxContainer to pack array/map walks.
Cap CLI stdin concat at MAX_STDIN_BYTES.
Document a risk-based bump window in SECURITY.md.

Closes #6 #7 #8 #9 #10 #11 #12 #13
Node treats any error listener as handling, so dropBuf on the
socket swallowed ECONNRESET. Drop the buffer, then emit on Stream
when !dead so rejectLimit plus destroy(err) does not double-fire.
@enochgroot

Copy link
Copy Markdown
Owner Author

Addressed review OPEN Low (9): Stream now re-emits underlying socket errors after dropBuf, gated on !dead so rejectLimit + destroy(err) still emits once. Tests cover socket-error forwarding and the rejectLimit once-only path. 80e77d0.

@enochgroot

Copy link
Copy Markdown
Owner Author

Superseded by a rebase onto live upstream 3.4.0 (c0f78a1). See msgpack#25695.

@enochgroot enochgroot closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant