Player hook: Fix cancelling when player is on wall#2212
Merged
Conversation
Do not call move_and_slide() and do not check if it is stuck when the thing being hooked has zero weight, which means the thing is pulled toward the player and the player doesn't move. There logic for "being stuck" should be revisited in the future. Because a character that isn't tring to move (has no velocity) shouldn't be considered stuck. This fixes a bug in which trying to pick a button when the player is next to a wall, moves the button a little because the hooking is cancelled. Fix #1807
|
Play this branch at https://play.threadbare.game/branches/endlessm/fix-hook-stopping/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
wjt
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not call move_and_slide() and do not check if it is stuck when the thing being hooked has zero weight, which means the thing is pulled toward the player and the player doesn't move.
There logic for "being stuck" should be revisited in the future. Because a character that isn't tring to move (has no velocity) shouldn't be considered stuck.
This fixes a bug in which trying to pick a button when the player is next to a wall, moves the button a little because the hooking is cancelled.
Fix #1807