[PLAT-5055] Fix pecl install step failing after successful build - #158
Merged
Conversation
yes exits 1 (not 141) on broken pipe in GitHub Actions, so the prior SIGPIPE guard still failed the step after a successful pecl install. Disable pipefail for the pipe and fail only when pecl returns non-zero. Co-authored-by: Cursor <cursoragent@cursor.com>
aspencer
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install-valkey-glidecomposite action failing CI after a successfulpecl installyesexits with code 1 (not 141) when the pipe closes in GitHub Actions; the prior SIGPIPE guard did not catch itpipefailfor theyes | peclpipe and fail only whenpeclreturns non-zero viaPIPESTATUS[1]Test plan
@main)Made with Cursor