Skip to content

Allow late print calls from terminating pthreads #27012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brendandahl wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −15
Open

Allow late print calls from terminating pthreads #27012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/lib/libpthread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,17 +591,6 @@ var LibraryPThread = {
dbg(`terminateWorker: ${worker.workerID}`);
#endif
worker.terminate();
// terminate() can be asynchronous, so in theory the worker can continue
// to run for some amount of time after termination. However from our POV
// the worker is now dead and we don't want to hear from it again, so we stub
// out its message handler here. This avoids having to check in each of
// the onmessage handlers if the message was coming from a valid worker.
worker.onmessage = (e) => {
#if ASSERTIONS
var cmd = e.data.cmd;
err(`received "${cmd}" command from terminated worker: ${worker.workerID}`);
#endif
};
},

_emscripten_thread_cleanup: (thread) => {
Expand Down
4 changes: 0 additions & 4 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6166,10 +6166,6 @@ def test_modularize_instantiation_error(self):

@crossplatform
@requires_pthreads
@flaky('https://github.com/emscripten-core/emscripten/issues/19683')
# The flakiness of this test is very high on macOS so just disable it
# completely.
@no_mac('https://github.com/emscripten-core/emscripten/issues/19683')
def test_pthread_print_override_modularize(self):
self.set_setting('EXPORT_NAME', 'Test')
self.set_setting('PROXY_TO_PTHREAD')
Expand Down
Loading