Re-enable the temporarily disabled circleci tests.#26996
Conversation
|
Locally esm-integration is broken, we'll see if it's the same here... |
| executor: linux-python | ||
| environment: | ||
| EMTEST_SKIP_NEW_CMAKE: "1" | ||
| EMTEST_SKIP_WASM64: "1" |
There was a problem hiding this comment.
Does bun not support wasm64?
There was a problem hiding this comment.
It probably does, but trying it out quickly it was failing. wasm64 tests use to be skipped on bun, so this really just restores the old behavior. I think we should enable in another PR.
There was a problem hiding this comment.
How were they skipped before? In general I try not to ever implicitly skip any tests. But maybe this case was one that I fixed recently ? (i.e. did I remove the implicit skipping?)
There was a problem hiding this comment.
It's the same reason as the deno commit in this PR. This commit changed how it worked. We use always skip deno and bun before that.
There was a problem hiding this comment.
I see yes, fair enough. They we being auto-skipped before.
Commit 347da58 enabled falling back to other engines in wasm64 requirement helpers if Node.js is missing, but changed the behavior when no capable engine is found from skipping to failing. This broke Deno- only testing environments where the wasm64 test variant was executed via crossplatform-only targets but failed due to Deno not being recognized as an eligible wasm64 JS engine. To resolve this, check for Deno and allow it as a valid wasm64 JS engine inside require_wasm64 helper.
brendandahl
force-pushed
the
re-enable-tests
branch
from
9827f6e to
1d8d1d7
Compare
2 participants
No description provided.