Repository navigation
Fix #94: admit promoted reflections in the project namespace on retrieve - #121
Merged
emp3thy merged 1 commit intoJul 31, 2026
Merged
Conversation
_fetch_reflection_buckets restricted the project namespace admit set to
{active} while reflection_list and the migrator both use {active,
promoted}: migrated confirmed reflections (scope=project, body status=
promoted) were parsed and then silently dropped, so every memory.retrieve
returned only pending_review rows. Widen the project admit set to match.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🟢 Claude BugBot Analysis
The diff widens the project-namespace status admit set from {"active"} to {"active", "promoted"} in _fetch_reflection_buckets, aligning it with reflection_list's documented default vocabulary; this is a scoped, self-consistent fix (project_ns remains actor-scoped so no cross-tenant leakage) with matching test updates, and no defects were found.
No bugs were detected in this PR.
emp3thy
deleted the
auto-fix/issue-94-agentcore-promoted-project-visibility
branch
July 31, 2026 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94
Summary
_fetch_reflection_bucketsrestricted the project-namespace admit set tofrozenset({"active"})whilereflection_list(agentcore.py:1043) and the migrator (agentcore_migrate.py:confirmed→"promoted",scope=project→projects/{p}/reflections/) both use{"active", "promoted"}. Any migratedconfirmedreflection therefore parsed cleanly and was then silently dropped at the status gate, somemory.retrieveandSessionStartreturned onlypending_reviewrows — the whole reviewed corpus went invisible. This PR widensallowed_projectto matchallowed_general(the safer of the two options the issue proposes), replaces the now-obsoletetest_retrieve_excludes_non_active_status_in_project_namespace(which encoded the contradictory "promoted-in-project must be excluded" contract) with two focused tests: one keeps the retired-exclusion guarantee, the other pins the migrated-confirmed visibility bug from #94. Fulltests/storage/+tests/cli/test_agentcore_migrate.pysuites pass (283/283).Confidence
~92%. The fix is precisely the one the issue names ("(safer) widen
allowed_projectto{active, promoted}to matchreflection_list, and fix the two contradictory tests together"): a two-line prod change and one test rewrite, in an area with dense existing coverage.This PR was generated by a scheduled Claude routine that scans open issues and opens PRs only when confidence ≥ 90%.
Generated by Claude Code