Skip to content

ci: run the gofmt check on every Go folder #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aswin-V merged 1 commit into from
Nov 10, 2026
+4 −1
Merged

ci: run the gofmt check on every Go folder #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,11 @@ jobs:

- name: Gofmt check
shell: bash
# Check every Go file in the module, not a hand-kept list of
# folders: the old list (cmd core transport) skipped config,
# examples, protocol, security, services and tests.
run: |
out=$(gofmt -l cmd core transport)
out=$(gofmt -l .)

@sourcery-ai sourcery-ai Bot Nov 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Skipped folders stay unchecked

When a later change narrows the command back to a folder list and the tree has no unformatted files, a later change that restores the old folder list leaves the clean tree green, so an unformatted file in a previously skipped folder passes CI without a regression test catching it.

Add a maintained regression test that verifies the check fails for an unformatted Go file in a previously skipped folder.

Prompt for AI agents 
In `.github/workflows/ci.yml` at line 43:

**Skipped folders stay unchecked**

When a later change narrows the command back to a folder list and the tree has no unformatted files, a later change that restores the old folder list leaves the clean tree green, so an unformatted file in a previously skipped folder passes CI without a regression test catching it.

Add a maintained regression test that verifies the check fails for an unformatted Go file in a previously skipped folder.

From TESTING.md L12:

- **Regression** — every fixed defect gets a test that would have caught it.

if [ -n "$out" ]; then
echo "::error::files need gofmt: $out"
exit 1
Expand Down
Loading