Repository navigation
docs: state the Go 1.26.10 minimum that go.mod requires - #58
Conversation
README.md and examples/hello-eipc/README.md said Go 1.22+, and the prerequisites table in CONTRIBUTING.md said 1.21+, but go.mod requires go 1.26.10. The floor was raised to 1.26.9 for the October security releases (48d4a4a) and then to 1.26.10 to distrust the compromised CA keys (2315c1f, #49). A Go 1.22 toolchain with GOTOOLCHAIN=local stops with "go.mod requires go >= 1.26.10".
|
ⓘ Your Qodo trial ends soon. Ask your workspace admin to set up billing to keep reviews running after the trial. Manage billing |
You've used all your free Kodus-paid PR reviews 🎁Your trial is still active — this just means the PR reviews we cover during the trial are used up. Connect your own AI key to keep Kody reviewing — unlimited reviews, on any plan (Free included). Want more trial reviews to finish evaluating before adding a key? Talk to our founders. 😎 |
Reviewer's GuideDocumentationUpdate the Go minimum in the project README and example README to match the requirement in go.mod.
Correct the Go version in the contributor prerequisites table to match the go.mod minimum.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
PR Summary by QodoAlign documented Go minimum with go.mod
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Linked issuesChecked at commit 3353732 #57 README and CONTRIBUTING say Go 1.22+ / 1.21+, but go.mod requires Go 1.26.10 · 3 of 3 met
|
|
Premise: pass — go.mod requires go 1.26.10; README.md:49 said Go 1.22+, CONTRIBUTING.md:9 said 1.21+, examples/hello-eipc/README.md:7 said Go 1.22+; all three now state 1.26.10 (docs-only, +3/-3). |
Summary
README.mdandexamples/hello-eipc/README.mdsaid "Go 1.22+" andCONTRIBUTING.md's prerequisites table said "1.21+", butgo.modrequiresgo 1.26.10. All three now state 1.26.10 and point at thegoline ingo.mod.Type of Change
Changes
README.md:49:Go 1.22+->Go 1.26.10 or newer (the go line in go.mod sets this minimum).examples/hello-eipc/README.md:7: the same line. The example builds from the root module, so it has the same minimum.CONTRIBUTING.md:9: the prerequisites table cell1.21+->1.26.10+ (the go line in go.mod).CONTRIBUTING.md:122(chore: bump go version to 1.22) is an example commit message, not a requirement, and is left alone.To find every place that names a Go version, including table cells:
On master
70748b2this prints exactly the three lines above. On this branch it prints nothing.Testing
Run on macOS 26 arm64 at
3353732. Go 1.22.12 and 1.26.10 were fetched with the Go toolchain mechanism (GOTOOLCHAIN=go1.x.y go version) and then run withGOTOOLCHAIN=local, so each one really is the version it reports.70748b2GOTOOLCHAIN=local go build ./...go: go.mod requires go >= 1.26.10 (running go 1.22.12; GOTOOLCHAIN=local)GOTOOLCHAIN=local go build ./...go.mod, masterdocs-check.sh <tree>(reads thegoline, runs the grep above over every non-Go file, fails on any match that is not 1.26.10)README.md:49,CONTRIBUTING.md:9,examples/hello-eipc/README.md:7go.mod, this branchgo build ./...,go vet ./...gofmt -l cmd core transportgo test -race -count=1 ./...book-build.ymlPre-Submission Checklist
Closing issue
Fixes #57
Screenshots / Logs
Go 1.22.12 against master, Go 1.26.10 against this branch, and the docs check before and after:
Additional Notes
The README gives the floor rather than a single version on purpose, so it stays right when a newer Go is used. If the floor in
go.modmoves again, this line moves with it.Summary by Sourcery
Documentation:
Summary by CodeRabbit