Repository navigation
MCP e2e: current-loop readback skips on every quad-DAC pod - #133
Merged
Merged
Conversation
…alog module too, not only v3r2) The firmware drives the 4-20 mA output from the quad DAC on analog v3r2 and on any board with an analog module (dac_quad_for_board); the 5 V loopback does not see that channel, so the test failed on a v3 board with a module (benchpod-c2f662, on 3.10.8 and on 4.0.0 alike). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_current_loop_terminals skipped only on board_rev v3r2, but the firmware uses the quad DAC on any board with an analog module too, so the 5 V loopback never sees the 4-20 mA output there. On benchpod-c2f662 (v3 + analog module 3.3) it failed the same way on firmware 3.10.8 with MCP 3.0.5 and on 4.0.0 with MCP 4.0.0. The skip now follows the firmware rule (v3r2 or module present+analog). Re-run on c2f662: 9 passed, this test skipped.
🤖 Generated with Claude Code