Skip to content

MCP e2e: current-loop readback skips on every quad-DAC pod - #133

Merged
wardviaene merged 1 commit into
mainfrom
mcp-test-quad-dac
Nov 20, 2026
Merged

wardviaene merged 1 commit into
mainfrom
mcp-test-quad-dac

Conversation

@wardviaene

Copy link
Copy Markdown
Member

test_current_loop_terminals skipped only on board_rev v3r2, but the firmware uses the quad DAC on any board with an analog module too, so the 5 V loopback never sees the 4-20 mA output there. On benchpod-c2f662 (v3 + analog module 3.3) it failed the same way on firmware 3.10.8 with MCP 3.0.5 and on 4.0.0 with MCP 4.0.0. The skip now follows the firmware rule (v3r2 or module present+analog). Re-run on c2f662: 9 passed, this test skipped.

🤖 Generated with Claude Code

…alog module too, not only v3r2)

The firmware drives the 4-20 mA output from the quad DAC on analog v3r2 and on any board
with an analog module (dac_quad_for_board); the 5 V loopback does not see that channel, so
the test failed on a v3 board with a module (benchpod-c2f662, on 3.10.8 and on 4.0.0 alike).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wardviaene
wardviaene merged commit dcbc435 into main Nov 20, 2026
20 checks passed
@wardviaene
wardviaene deleted the mcp-test-quad-dac branch November 20, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant