Repository navigation
Digital board v3r4: 5 V I/O, pin 21, pull strength (SDK + MCP) - #123
Merged
Merged
Conversation
SDK: set_la_voltage(5.0) on a pod with the la_5v feature (the bank stays at 3.3 V, J1 pin 21 goes to 5 V); other pods get ValueError before anything is sent. Wiring la_mv takes 5000. LaVoltage.pin21 (new Pin21) reports pin 21's source, setting, measured voltage and state on v3r4. Capabilities.vref_out is the hardware fact. PullState.strength reports what the pod picked; la_pins() takes the reply's pull_dirs. No new parameters: the pod picks the strength. MCP: set_la_voltage takes 5.0 and an omitted voltage (read only) and returns pin21; connect and --la-voltage take 5.0; capabilities has vref_out; pull channels have strength. Feature map (revision 7) and error catalog (BP0028, BP0029) synced from benchpod-firmware#178. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…entries on v3r4
- la_pins(la=...) lists only those channels. Firmware after 3.10.12 sends only them, older firmware
sends all 14 and the SDK filters. A full listing answered with "reply too large" is read in two
parts (LA1-7, LA8-14).
- PullState.held (and MCP pull_status/set_pull "held"): why a pull that was set is off now on
digital v3r4 (pin21_down, dut_off, fault). enabled/state are the live state (firmware #181).
- la_dir() and gpio entries on v3r4 had pull_dirs ("up",) only: their replies leave dirs out and
have no pull_dirs. They now get ("up","down") when the pod has la_pull_strength.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A full la_pins listing that older firmware answers with "reply too large" (it has no la subset, so the SDK cannot read it in parts) now says that firmware after 3.10.12 reads it in parts, how to update, and that bp.la_pins(la=[...]) asks for fewer channels. Like the status hint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The SDK README, the set_la_voltage docstring and the MCP tool point to embeddedci.com/docs/benchpod-targets/5v-rs485#5v-io instead of explaining 5 V I/O again. The README no longer says the pod has no 5 V I/O (only boards before v3r4). The MCP instructions and la-voltage-not-set hints name 5.0 on a digital v3r4 pod. The docstring named the lease code BP0025 for a 5 V that did not come up; it is BP0028 (the test fake had it too). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wardviaene
force-pushed
the
digital-v3r4
branch
from
November 19, 2026 17:38
e80f808 to
8a46d79
Compare
wardviaene
enabled auto-merge (squash)
November 19, 2026 17:38
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Host side of the digital board v3r4 firmware stack: embeddedci-com/benchpod-firmware#175, embeddedci-com/benchpod-firmware#176, embeddedci-com/benchpod-firmware#178. Merge after those (the bundled feature map and error catalog come from #178).
SDK
set_la_voltage(5.0)whensupports("la_5v"): sendsmv: 5000. Every other pod raisesValueErrorbefore anything is sent, so an older board sees no new traffic. Other bad values name 5.0 only where the pod has it.LaVoltage.pin21: newPin21(source,setting,measured,state,up,ok) from the reply'svref_out;Noneon other boards.Capabilities.vref_outfrom thehwfacts.Wiringacceptsla_mv: 5000.PullState.strength(10k,2.2k,both,none).la_pins()passes the reply'spull_dirsto each entry (v3r4 entries leavedirsout to fit the cloud reply)."strength"for a rawcommand()if ever needed.la_5v6,la_pull_strength7) and error catalog (BP00285 V did not come up,BP0029pin 21 is down).MCP
set_la_voltage:5.0allowed;voltageoptional (omitted = read); returnspin21and tells the agent whathighmeans.connect(la_voltage=5.0),--la-voltage 5.0.capabilities.vref_out; pull channels havestrength;board_revdescription lists v3r2/v3r4.set_la_voltage.voltagebecame optional).Tests: new
test_digital_v3r4.py(v3r4 pod and an older pod: capabilities, 5 V, BP0028, refusal before sending, strength, pull_dirs, profile). MCP e2eset_la_voltagecheck no longer compares the whole dict (the result now haspin21). All unit suites pass;test_bundled_copy_matches_the_firmwarepasses against the firmware branch (BENCHPOD_FIRMWARE_DIR) and skips in CI.Not testable without a v3r4 board: everything that needs the real pin 21 and expanders. On today's boards the regression run (hwe2e and SDK e2e on benchpod-30a9f1) is reported on the firmware PRs.
🤖 Generated with Claude Code