Skip to content

current_in: the pod's sense resistance, 100 ohm on analog module v3r5 - #120

Merged
wardviaene merged 4 commits into
mainfrom
current-in-100r
Nov 19, 2026
Merged

wardviaene merged 4 commits into
mainfrom
current-in-100r

Conversation

@wardviaene

Copy link
Copy Markdown
Member

Analog module v3r5 has a 100 ohm sense resistor on the 4-20 mA input (249 ohm before). Firmware 3.10.13+ (embeddedci-com/benchpod-firmware#174) reports what it converts with as sense_mohm, and reads current_in in the ADC low range unless a range is given.

  • AdcReading.sense_ohms, Calibration.sense_ohms (None on older firmware, which is always 249 ohm).
  • capture_adc / capture_correlated on current_in compute currents with the pod's value, 249 ohm when it does not say.
  • The SDK follows the automatic low range (its cached fit), and drops it again after a DAC route (dac_output, generate, replay), where the pod puts the range back without reporting it. A range the user chose is left alone.
  • MCP adc_read returns sense_ohms; the guide mentions the 30 mA limiter (readings stuck near 28.5 to 31.5 mA).
  • OpenHTF logs the reported resistor; the e2e J8-open check uses it.
  • README table for both revisions (4 / 20 mA voltages, voltage taken from the loop, default range, resolution, measurable range), changelogs, API snapshot.

Tests: new test_current_in_shunt.py (v3r4 and v3r5 fakes: readings, captures, the automatic range and its return), MCP tool test. make test: 1054 / 209 / 74 / 12 passed (with BENCHPOD_FIRMWARE_DIR pointing at a current firmware checkout for the feature map check).

Not hardware-tested: no v3r5 module exists yet. Not released.

🤖 Generated with Claude Code

wardviaene and others added 4 commits November 19, 2026 11:32
Analog module v3r5 has a 100 ohm sense resistor on the 4-20 mA input (249 ohm before), and
firmware 3.10.13+ reports what it converts with (sense_mohm).

- AdcReading.sense_ohms and Calibration.sense_ohms.
- capture_adc / capture_correlated on current_in compute currents with the pod's value (249 ohm
  when the firmware does not say).
- On v3r5 the pod reads current_in in the low range by default and gives it back on the next
  route: the SDK follows, also after a DAC output route (dac_output, generate, replay) where the
  pod does not report the range.
- MCP adc_read returns sense_ohms; the guide explains the 30 mA limiter.
- README, changelogs, API snapshot.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…inned SDK)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…elease row)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wardviaene
wardviaene enabled auto-merge (squash) November 19, 2026 17:34
@wardviaene
wardviaene merged commit 2bec19a into main Nov 19, 2026
20 checks passed
@wardviaene wardviaene mentioned this pull request Nov 19, 2026
@wardviaene
wardviaene deleted the current-in-100r branch November 20, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant