Skip to content

USB console: a log line right after the prompt ends the reply - #116

Merged
wardviaene merged 1 commit into
mainfrom
serial-prompt-trailing-log
Nov 19, 2026
Merged

wardviaene merged 1 commit into
mainfrom
serial-prompt-trailing-log

Conversation

@wardviaene

Copy link
Copy Markdown
Member

Firmware up to 3.10.12 prints [sig] SPI1 link at 3906250 Hz (/64) for gateware 58 from the hw task on every status. The line can land after the > prompt, so the reply ends > [sig] ...\r\n with no new prompt and _read_until_prompt timed out. In the 3.10.12 pre-tag e2e, test_e2e_usb.py::test_network_only_features_fail_fast failed in about 1 of 3 runs because of this.

  • SerialTransport._read_until_prompt: a prompt followed only by complete [tag] ... lines now ends the reply, and those lines are dropped. A partial log line still waits, and a log line in the middle of a reply is not taken for a prompt.
  • Unit tests: test_a_log_line_after_the_prompt_ends_the_reply replays that exact sequence (it fails without the fix), plus regex edge cases.
  • CHANGELOG: Unreleased entry.

The firmware side, which stops printing the line on every status, is a separate PR in benchpod-firmware.

Unit tests: packages/embeddedci 1005 passed. test_feature_map.py::test_bundled_copy_matches_the_firmware fails without this change too: it compares against the sibling firmware checkout.

🤖 Generated with Claude Code

Firmware up to 3.10.12 prints '[sig] SPI1 link at ... for gateware 58' from the hw task on every
status; it can land after the '> ' prompt, and _read_until_prompt then timed out
(test_e2e_usb::test_network_only_features_fail_fast flaked about 1 in 3 runs on 3.10.12).
A prompt followed only by complete [tag] lines now ends the reply.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wardviaene
wardviaene merged commit 075117d into main Nov 19, 2026
20 checks passed
@wardviaene
wardviaene deleted the serial-prompt-trailing-log branch November 19, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant