Repository navigation
USB console: a log line right after the prompt ends the reply - #116
Merged
Merged
Conversation
Firmware up to 3.10.12 prints '[sig] SPI1 link at ... for gateware 58' from the hw task on every status; it can land after the '> ' prompt, and _read_until_prompt then timed out (test_e2e_usb::test_network_only_features_fail_fast flaked about 1 in 3 runs on 3.10.12). A prompt followed only by complete [tag] lines now ends the reply. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firmware up to 3.10.12 prints
[sig] SPI1 link at 3906250 Hz (/64) for gateware 58from the hw task on everystatus. The line can land after the>prompt, so the reply ends> [sig] ...\r\nwith no new prompt and_read_until_prompttimed out. In the 3.10.12 pre-tag e2e,test_e2e_usb.py::test_network_only_features_fail_fastfailed in about 1 of 3 runs because of this.SerialTransport._read_until_prompt: a prompt followed only by complete[tag] ...lines now ends the reply, and those lines are dropped. A partial log line still waits, and a log line in the middle of a reply is not taken for a prompt.test_a_log_line_after_the_prompt_ends_the_replyreplays that exact sequence (it fails without the fix), plus regex edge cases.The firmware side, which stops printing the line on every status, is a separate PR in benchpod-firmware.
Unit tests:
packages/embeddedci1005 passed.test_feature_map.py::test_bundled_copy_matches_the_firmwarefails without this change too: it compares against the sibling firmware checkout.🤖 Generated with Claude Code