Repository navigation
Pull resistors by direction: set_pull(la, "up"|"down"|"off"), wiring pulls map, MCP pull= - #112
Merged
Merged
Conversation
Member
Author
|
HW verification on benchpod-30a9f1 (analog v3r2, gw 58), pod lock held, restored to the published 3.10.11 afterwards. Dev build of this branch (DFU):
Released 3.10.11 (fallback path): SDK e2e gpio+pod 101 passed / 8 skipped (incl. the new |
…pulls map, MCP pull=
SDK: set_pull(la, pull) names the direction and returns PullState with state,
supported and ohms; True/False and enabled= stay (deprecated: True = the
channel's own direction). Firmware with la_pull_dir gets {"pull":...}; older
firmware gets pullup on/off and the SDK checks the direction itself. BP0023 /
BP0024 raise PullDirectionError (also a ValueError). The board's resistors are
one table, constants.PULL_TABLE. Wiring.pulls takes a map {la: "up"|"down"}
next to the list; pull_directions() and power_on use it. Error catalog and
features table synced from benchpod-firmware#167.
MCP: set_pull(las, pull="up"|"down"|"off") (enabled still works), channels
1-14; pull_status lists all 14 with state and supported; guide, README and
set_wiring's pulls text updated. Works against embeddedci 3.0.2 too (checks
the direction itself there).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the pulls list when every pull is its own direction Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wardviaene
force-pushed
the
pull-direction
branch
from
November 19, 2026 00:15
dcbbb1a to
08fe51a
Compare
Merged
wardviaene
added a commit
that referenced
this pull request
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosts for embeddedci-com/benchpod-firmware#167: the pull-resistor API names a direction instead of on/off, on today's boards, so it is final before the next digital board (up/down on every channel).
Rebased onto main after #111 and #113 merged.
SDK (
embeddedci)set_pull(la, "up" | "down" | "off")(None is off) returnsPullStatewithstate,supported(directions the channel can pull) andohms. The pod picks the resistor.enable_pullup/disable_pullup/enable_pulldown/disable_pulldownstay as shortcuts.set_pull(la, True/False)andenabled=still work (deprecated: True = the channel's own direction).la_pull_dirgets{"pull": ...}; older firmware getspullupon/off and the SDK checks the direction itself, so"up"never engages LA7's pull-down on 3.10.11.PullDirectionError(aFirmwareErrorand aValueError, which these refusals raised before), withla,want,have.constants.PULL_TABLE(PullHw);PULL_OHMS,PULLUP_CHANNELS,PULLDOWN_CHANNELSderive from it.Wiring.pullstakes a map{"1": "up", "8": "down"}; the list of channels stays valid and means each channel's own direction.Wiring.pull_directions();power_onapplies it.test_pull_by_direction(works on old and new firmware).MCP (
embeddedci-mcp)set_pull(las, pull="up"|"down"|"off"), channels 1-14;enabledstill works.pull_status: all 14 channels withstateandsupported.set_wiring'spullstext updated.Tests
pytest packages/embeddedci1002 passed;packages/embeddedci-mcp209 passed (also against PyPI embeddedci 3.0.2); openhtf 74; scripts 12.🤖 Generated with Claude Code