Repository navigation
Capabilities from the features table for firmware after 3.10.10 - #105
Merged
Merged
Conversation
The SDK ships benchpod-firmware's features/features.json (feature_map.json, scripts/sync-feature-map.sh) and reads the pod's status with "caps":false. Firmware that answers with features_rev gets its features from the table (Capabilities.features, has(), fpga_image); older firmware ignores the argument and sends its caps list, read as before. supports() also takes table names without a flag (la_dir, i2c_master, diag, ...). A pod with a newer table than the SDK logs one warning to update the SDK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reader side of embeddedci-com/benchpod-firmware#162.
benchpod/feature_map.json, a copy of benchpod-firmware'sfeatures/features.json;scripts/sync-feature-map.sh), so deciding what a pod can do needs no network.statuswith"caps":false(Transport.status_without_caps). Firmware that answers withfeatures_revgets its features from the table (Capabilities.features,has(),fpga_image, thehwfacts); older firmware ignores the argument and sends its caps list, read as before.BenchPod.status()itself is unchanged.supports()also takes table names without a flag of their own (la_dir,i2c_master,diag, ...).la_dirandbus_masteruse the table when the pod has it.Tests:
test_feature_map.py(the table gives a 3.10.10 analog pod everything its caps list gave; images, gateware, digital board, revisions; the client sendscaps:false; the bundled copy equals the firmware sibling when present). Full suite: 981 passed. API surface snapshot refreshed (additive).Not released; release before the firmware so old-firmware pods and new ones both work.
🤖 Generated with Claude Code