Skip to content

Improve shell command message when agent is empty - #1987

Merged
igordayen merged 2 commits into
embabel:mainfrom
deleSerna:ghissue-1741
Aug 30, 2026
Merged

igordayen merged 2 commits into
embabel:mainfrom
deleSerna:ghissue-1741

Conversation

@deleSerna

@deleSerna deleSerna commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #1741
Most of the changes are taken from #1786 (Contributed by @simeshev)

Changes:

  • Added an explicit empty-state response for the agents shell command and preserve detailed output + a concise summary when agents exist.
  • Improved agent registration failure warnings.
  • Adjusted logging severity when an agent process runs with no goals (where goals are required).

Test

  • Added tests in ShellCommandsAgentsTest
  • Tested on a real agent application with embabel.agent.api.validation.manager.skip-agent-deployment-on-error=true and agent did not have any actions/goal/conditions and No agents registered displayed as expected.
   00:06:01.831 [main] WARN  AgentMetadataReader - No @EmbabelComponent or @Agent annotation found on org.springframework.shell.boot.TerminalUIAutoConfiguration
00:06:01.831 [main] WARN  AgentMetadataReader - No @EmbabelComponent or @Agent annotation found on org.springframework.shell.component.ViewComponentExecutor
00:06:01.831 [main] INFO  DelegatingAgentScanningBeanPostProcessor - All deferred beans were post-processed.
00:06:01.836 [main] INFO  Agent101Application - Started Agent101Application in 1.241 seconds (process running for 1.362)
embabel> 
<===<====No agents registeredTING [29s]
embabel> n
<===========--> 88% EXECUTING [1m 1s]

Signed-off-by: deleSerna <nadeeshtv@gmail.com>
@deleSerna

Copy link
Copy Markdown
Contributor Author

@igordayen @simeshev ready for review

@igordayen igordayen added this to the 1.5.2-Release🔵 milestone Aug 30, 2026

@igordayen igordayen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deleSerna - looks good, but please verify semantic of "Agentic Component".

Also could you please confirm the level of testing outside unit testing, thanks

@deleSerna

Copy link
Copy Markdown
Contributor Author

but please verify semantic of "Agentic Component".

Will do

Also could you please confirm the level of testing outside unit testing, thanks

As mentioned din the description, tested on a real agent application with embabel.agent.api.validation.manager.skip-agent-deployment-on-error=true and agent did not have any actions/goal/conditions and No agents registered displayed as expected.

Signed-off-by: deleSerna <nadeeshtv@gmail.com>

@igordayen igordayen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deleSerna - looks good to me, thank you

@igordayen
igordayen merged commit c1a2087 into embabel:main Aug 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the warning message when Agent does not meet the necessary criteria to register as an Agent

2 participants