fix: migrate Java examples to Spring Shell 4 - #138
Open
arnabnandy7 wants to merge 1 commit into
Open
arnabnandy7 wants to merge 1 commit into
arnabnandy7 wants to merge 1 commit into
Conversation
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ShellComponent,@ShellMethod, and@ShellOptionto Spring Shell 4 annotations.string-joke,object-joke,travel-report,bank-support, andcook.Background
This is a downstream compatibility update for:
Before this change, the examples selected Spring Shell 3.4 core and starter artifacts alongside Spring Shell 4.0.2 components supplied by Embabel Agent. The resulting mixed classpath prevented migrated Embabel commands from being registered correctly.
Verification
examples-javaagainstembabel-agent.version=1.5.2-SNAPSHOT.git diff --checkpasses.help, command discovery, and tab completion.Closes #137.