Skip to content

fix: migrate Java examples to Spring Shell 4 - #138

Open
arnabnandy7 wants to merge 1 commit into
embabel:mainfrom
arnabnandy7:fix/spring-shell-4-migration
Open

arnabnandy7 wants to merge 1 commit into
embabel:mainfrom
arnabnandy7:fix/spring-shell-4-migration

Conversation

@arnabnandy7

@arnabnandy7 arnabnandy7 commented Sep 9, 2026

Copy link
Copy Markdown

Summary

  • Align the Java examples with Spring Shell 4.0.2.
  • Remove the explicit Spring Shell 3.4 dependency that produced a mixed 3.4/4.0 runtime.
  • Migrate example shell commands from @ShellComponent, @ShellMethod, and @ShellOption to Spring Shell 4 annotations.
  • Preserve existing command names such as string-joke, object-joke, travel-report, bank-support, and cook.

Background

This is a downstream compatibility update for:

Before this change, the examples selected Spring Shell 3.4 core and starter artifacts alongside Spring Shell 4.0.2 components supplied by Embabel Agent. The resulting mixed classpath prevented migrated Embabel commands from being registered correctly.

Verification

  • Confirmed the dependency tree resolves Spring Shell artifacts consistently at version 4.0.2.
  • Compiled examples-java against embabel-agent.version=1.5.2-SNAPSHOT.
  • Confirmed git diff --check passes.
  • Run the Java horoscope example interactively and verify help, command discovery, and tab completion.
  • Run the complete repository test suite.

Closes #137.

Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Java examples to Spring Shell 4

1 participant