Conversation
Signed-off-by: guanxu <1510424541@qq.com>
jimador
left a comment
jimador
left a comment
There was a problem hiding this comment.
Looks great! Thank you. Just a couple of house keeping comments for existing clients.
| import org.springframework.http.ResponseEntity | ||
| import org.springframework.web.bind.annotation.* | ||
| import org.springframework.web.multipart.MultipartFile | ||
| import tools.jackson.databind.ObjectMapper |
There was a problem hiding this comment.
Can we verify that existing consumers can still start and use Dice JSON with Jackson 2 on the classpath? If not, this needs a compatibility period before changing the public ObjectMapper type.
| class PropositionJacksonRoundTripTest { | ||
|
|
||
| private val mapper = jacksonObjectMapper().findAndRegisterModules() | ||
| private val mapper = jacksonObjectMapper() |
There was a problem hiding this comment.
Can we add a JSON fixture written by the Jackson 2 repository and load it here? This only tests a Jackson 3 round trip, so it does not cover existing persisted data.
|
Carrying a note over from the review of #84:
|
3 participants
No description provided.