Skip to content

fix(dropdown): block popup actions while disabled - #185

Open
Xapollon430 wants to merge 1 commit into
elreco:mainfrom
Xapollon430:codex/dropdown-disabled-popup-actions
Open

Xapollon430 wants to merge 1 commit into
elreco:mainfrom
Xapollon430:codex/dropdown-disabled-popup-actions

Conversation

@Xapollon430

Copy link
Copy Markdown

Fixes #184.

Problem

  1. Open an enabled Dropdown with an action that changes the app value from Apple to Orange.
  2. Set disabled to true while the popup is open.
  3. Click Orange. The action runs and the app value changes.

A reactive update can disable the trigger after someone has opened its menu. The React implementation now passes the disabled state to the Base UI menu root. The Vue implementation passes it to the Reka menu items and checks it in the selection handler. Both render disabled links without a navigation target.

Validation

  • The Vue and React regressions fail before the fix and pass afterward. Both check action callbacks, disabled semantics, and link targets.
  • Real Chrome clicks on each implementation changed Apple to Orange and emitted one action on main. With the fix, both kept Apple and emitted zero actions.
  • The required pnpm check passes, including all 246 tests, both package builds, distribution smoke checks, and installed CLI/MCP checks.

Vue Chrome reproduction · React Chrome reproduction

AI-assisted implementation and testing.

@netlify

netlify Bot commented Nov 12, 2026

Copy link
Copy Markdown

👷 Deploy request for vue-tailwind-datepicker pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 06f6685

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown still runs menu actions after becoming disabled

1 participant