Conversation
Replace pinned variables in binary pattern sizes (^var) with :erlang.split_binary/2 to support both Elixir 1.12+ and 1.20+ without warnings.
Coverage Report for CI Build 0Coverage increased (+0.01%) to 87.782%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
persistent_term has been available since OTP 21.2 and Mint requires Elixir ~> 1.12 which needs OTP 22+, so it is always available. Remove the runtime check, the application env, and the empty supervisor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace pinned variables in binary pattern sizes (
^var) witherlang.split_binary/2to support both Elixir 1.12+ and 1.20+ without warnings.Need this to vendor Mint into Hex.