Skip to content

Workaround for crashing when many tooltips are shown consecutively #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryonakano merged 4 commits into from
Apr 18, 2026
Merged

Workaround for crashing when many tooltips are shown consecutively #563

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c5b953
BaseItem: Avoid crashing when many tooltips are shown consecutively
flodavid Jan 18, 2026
b6968f1
Repace waiting flag by event id and GLib.Source.remove
flodavid Mar 13, 2026
ff041eb
Update style to address PR feedback
flodavid Apr 8, 2026
beee2a2
Merge branch 'main' into wayland-crash-workaround
ryonakano Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions src/BaseItem.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public class Dock.BaseItem : Gtk.Box {

private int drag_offset_x = 0;
private int drag_offset_y = 0;
private uint open_tooltip_timeout_id = 0;

protected BaseItem () {}

Expand Down Expand Up @@ -150,11 +151,15 @@ public class Dock.BaseItem : Gtk.Box {

var motion_controller = new Gtk.EventControllerMotion ();
motion_controller.enter.connect (() => {
if (!popover_menu.visible && tooltip_text != null) {
popover_tooltip.popup ();
this.wait_and_show_tooltip (100);
Comment thread
flodavid marked this conversation as resolved.
Outdated
});
motion_controller.leave.connect (() => {
if (open_tooltip_timeout_id > 0) {
GLib.Source.remove (open_tooltip_timeout_id);
Comment thread
flodavid marked this conversation as resolved.
}

if (popover_tooltip.visible) popover_tooltip.popdown ();
Comment thread
flodavid marked this conversation as resolved.
Outdated
});
motion_controller.leave.connect (popover_tooltip.popdown);

add_controller (motion_controller);

Expand Down Expand Up @@ -315,6 +320,23 @@ public class Dock.BaseItem : Gtk.Box {
return obj != null && obj is BaseItem && ((BaseItem) obj).group == group;
}

private void wait_and_show_tooltip (uint delay_ms) {
if (!popover_menu.visible && tooltip_text != null) {
// Add timeout to avoid "Error 71 (Protocol error) dispatching to Wayland display".
// This error is probably caused by a bug in GTK caused by the Nvidia driver at least up to v580.
// Documented in issue #559 on the Github project.
Comment thread
flodavid marked this conversation as resolved.
Outdated

open_tooltip_timeout_id = GLib.Timeout.add (delay_ms, () => {
Comment thread
flodavid marked this conversation as resolved.
Outdated
open_tooltip_timeout_id = 0;
if (!popover_menu.visible) {
popover_tooltip.popup ();
}

return false;
});
}
}

private class PopoverTooltip : Gtk.Popover {
class construct {
set_css_name ("tooltip");
Expand Down
Loading