Repository navigation
ci: bump electron/secret-service-action to v1.1.0 - #317
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ELojQikqpZ2KVGqjEeNwUe
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. The action it bumps fetches the release secrets for the npm publish job, so a human should still confirm the new pin.
What was reviewed:
- The one-line pin change in
.github/workflows/release.yml. It is still a full 40-character SHA with a version comment, which matches how the other actions are pinned. - The later step still reads
steps.secret-service.outputs.secretsand parses it as JSON to getGITHUB_TOKEN. v1.1.0 needs to keep producing that output in the same shape. - I couldn't check from here that
23b9042f…is the commit tagged v1.1.0 in electron/secret-service-action, or what changed between the two versions.
Extended reasoning...
This changes one line in the release workflow: the electron/secret-service-action pin moves from the v1.0.0 SHA to a SHA labeled v1.1.0. The action runs in the release job, which has id-token: write and the npm-trusted-publisher environment, and its output provides the GitHub token used by semantic release. That makes it supply-chain and secret-handling code. The repo's CODEOWNERS file assigns all paths (*) to an owning team, and I couldn't confirm that the new SHA matches the upstream v1.1.0 tag. Both of those point to a human review rather than approval.
Requested by Samuel Attard · Slack thread
Bumps secret-service-action to v1.1.0, which points the secret exchange at secret-service's new home on ionic (secret-service.electronjs.org) instead of Heroku.
Generated by Claude Code