Skip to content

ci: bump electron/secret-service-action to v1.1.0 - #317

Merged
MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0
Oct 22, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0

Conversation

@claude

@claude claude Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

Bumps secret-service-action to v1.1.0, which points the secret exchange at secret-service's new home on ionic (secret-service.electronjs.org) instead of Heroku.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ELojQikqpZ2KVGqjEeNwUe
@claude
claude Bot requested a review from a team as a code owner October 22, 2026 21:37

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. The action it bumps fetches the release secrets for the npm publish job, so a human should still confirm the new pin.

What was reviewed:

  • The one-line pin change in .github/workflows/release.yml. It is still a full 40-character SHA with a version comment, which matches how the other actions are pinned.
  • The later step still reads steps.secret-service.outputs.secrets and parses it as JSON to get GITHUB_TOKEN. v1.1.0 needs to keep producing that output in the same shape.
  • I couldn't check from here that 23b9042f… is the commit tagged v1.1.0 in electron/secret-service-action, or what changed between the two versions.
Extended reasoning...

This changes one line in the release workflow: the electron/secret-service-action pin moves from the v1.0.0 SHA to a SHA labeled v1.1.0. The action runs in the release job, which has id-token: write and the npm-trusted-publisher environment, and its output provides the GitHub token used by semantic release. That makes it supply-chain and secret-handling code. The repo's CODEOWNERS file assigns all paths (*) to an owning team, and I couldn't confirm that the new SHA matches the upstream v1.1.0 tag. Both of those point to a human review rather than approval.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 21:42
@MarshallOfSound
MarshallOfSound merged commit c2a897c into main Oct 22, 2026
9 checks passed
@MarshallOfSound
MarshallOfSound deleted the bump-secret-service-action-v1.1.0 branch October 22, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants