Conversation
Build linux/amd64 and linux/arm64 into one manifest, and retag latest on that same push so a hand release matches Buildkite.
Same as Elasticsearch local dockerBuild: native platform, --load, then run --help. Publish stays on Buildkite main. Co-authored-by: Cursor <cursoragent@cursor.com>
GitHub Actions cannot pull docker.elastic.co/wolfi/jdk. Image build and publish stay on Buildkite, which already logs in. Co-authored-by: Cursor <cursoragent@cursor.com>
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
docker-build.sh,push-docker.sh, and the Buildkite docker step use the samebuildxpath as Elasticsearch:linux/amd64andlinux/arm64combined into one Docker manifest.https://github.com/elastic/elasticsearch/blob/main/distribution/docker/README.md (section "Multi-architecture images")
push-docker.shbuilds and pushes:${VERSION}and:latestin one--push(version from the argument, orgradle.properties)docker-build.shbuilds the same platforms locally (no push):lateston the same manifest-f Dockerfileand.as the context. No-${arch}tags and no digest scrapingCloses [Docker] Align release scripts with Buildkite multi-arch; retag latest and arch manifests #1072
Tracker: https://github.com/elastic/support-tech-lead/issues/1959
Test plan
./docker-build.shcompletes forlinux/amd64,linux/arm64./push-docker.sh(or./push-docker.sh 9.4.2) pushes both tagsdocker buildx imagetools inspect docker.elastic.co/support/diagnostics:<version>shows both platformsdocker buildx imagetools inspect docker.elastic.co/support/diagnostics:latestshows the same digestAssisted by Cursor 🤖