Repository navigation
[EIS] Add Decision models to the sheet sync and supported models page - #9035
Draft
theletterf wants to merge 2 commits into
Draft
theletterf wants to merge 2 commits into
theletterf wants to merge 2 commits into
Conversation
Add a decision-models.csv output filtered on the Decision type, a Decision models section on the supported models page, and write a header-only CSV when a filter matches no rows. Related to elastic/docs-eng-team#1130 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Elastic Docs AI PR menuCheck the box to run an AI review for this pull request.
Powered by GitHub Agentic Workflows and docs-actions. For more information, reach out to the docs team. |
Contributor
🔍 Preview links for changed docs |
Contributor
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Member
Author
|
+CC @elastic/developer-docs @seanhandley Ready to merge when the new Decision models come out. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sean Handley let me know today that the EIS catalog is adding decision models, under a new
Decisiontask type. The first one, a Jina Decision model, launches next month. This PR gets the sheet-to-docs automation ready for it.The sync filters the
Typecolumn by exact match, soDecisionrows would have been dropped silently. Sean confirmed it's a new type value and not a new column, so the fix is small.config.yml: adds adecision-models.csvoutput that filters onDecision.eis-supported-models.md: adds a "Decision models" section with acsv-include.decision-models.csv: a header-only seed file, so the page builds before the sync generates real data.sync_sheet.py:write_csvnow writes a header row when a filter matches nothing. Its comment already said so, but it wrote a 0-byte file.I built the docs locally with
docs-builder(0 errors, 0 warnings). With no rows, the section renders a table with only its header row. I tested thewrite_csvchange in isolation. I have not run the workflow end to end.The
TypestringDecisioncomes from Sean's message. The sheet has noDecisionrows yet, so I couldn't confirm it there. Please check it when the first row lands.I opened this as a draft because merging today would publish an empty table. I'd merge it when the first Decision model row appears in the sheet, then run the workflow with
dry_runto confirm the CSV fills in. I left the unusedmodels.csvalone; that cleanup can be a separate PR.Related to elastic/docs-eng-team#1130
🤖 Generated with Claude Code