chore(ci): pin config-resolver release-as 0.1.1 to suppress spurious bump - #579
Merged
Merged
Conversation
…bump An empty commit (f892744) with a fix: prefix was pushed to main as part of PR #565. Because it has no file changes, release-please cannot attribute it to a specific package and includes it in the config-resolver changelog, triggering a spurious 0.1.1 -> 0.1.2 patch bump in release PR #573. Setting release-as to the current version overrides the computed bump and keeps config-resolver at 0.1.1. Per release-please docs, this directive should be removed once the release PR merges, or kept to permanently prevent auto-bumps until a real change lands in packages/config-resolver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Empty commit
f892744(currently HEAD onmain) carries twofix:lines in its message but changes zero files. Because release-please cannot path-attribute a file-less commit to any specific package, it falls through to every component in the manifest — includingconfig-resolver. This caused PR #573 to include a spurious0.1.1 → 0.1.2patch bump forconfig-resolverdespite nothing inpackages/config-resolver/actually changing.Fix
Add
"release-as": "0.1.1"to thepackages/config-resolverentry in.github/release-please-config.json. This overrides the computed next version for that component only, keeping it at0.1.1while allowing the root@elastic/clipackage to bump normally.Merging this PR will trigger the release workflow, which will regenerate PR #573 without the spurious
config-resolverbump.Follow-up
Per the release-please docs,
release-asis a persistent override and should be removed after the release PR merges, or left in place to act as a permanent parking brake forconfig-resolverauto-bumps. See the commit message for the tradeoffs.