Repository navigation
Release captured PHP error before executor shutdown - #1512
Closed
vova-tarasov wants to merge 1 commit into
Closed
vova-tarasov wants to merge 1 commit into
vova-tarasov wants to merge 1 commit into
Conversation
🤖 GitHub commentsJust comment with:
|
Contributor
|
Hi @vova-tarasov |
Author
|
closing this PR in favor of #1510 |
Contributor
|
Thank you for your contribution @vova-tarasov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.2.35 / 8.3.36 (the php2shell security release) set
EG(objects_store).object_bucketsto NULL inshutdown_executor()on fast shutdown, so releasinglastErrorDatain post-deactivate now segfaults whenever the captured backtrace holds an object argument:function f($o) { @trigger_error("x", E_USER_DEPRECATED); } f(new stdClass);exits with 139 on agent 1.13.0 through 1.17.0, in CLI and php-fpm. This releases it at the end of RSHUTDOWN while the executor is still alive, keeping the post-deactivate reset as a fallback; error events are still reported.