Repository navigation
Conversation
The community page gains a Hall of Shame beside the Hall of Suckers, with five boards: Saltiest, Salt of the Week, Most Punchable, Whiff Champion, and Biggest Loser. Shame boards count rage-quit games, so quitting never hides a player from them, and a rage quit counts on Biggest Loser at the margin when the player quit. Player profiles list shame ranks in their own red group on the Ranks tab. Sucker is a community, so everyone is on every board. The "Show me on leaderboards" toggle is gone and no query reads show_on_leaderboards; the column stays, always true, so installed apps that read or set it keep working. Leaderboard rows now take their accessible name from their content, which axe-core 4.14 requires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The community page gets a Hall of Shame next to the Hall of Suckers. It ranks the funny bad stuff, and rage quits are at the center of it.
docs/community-leaderboards.md.profiles.show_on_leaderboards. The column stays, set totruefor everyone, andget_player_cardalways returnstruefor it, so installed apps that read or toggle it keep working. It can be dropped once those versions age out.Rollout
The migration only replaces
ranked_leaderboard,get_player_rankingsandget_player_card, and keeps their return types. No Edge Function deploy is needed, and older apps keep working against it.Testing
npm run typecheck,npm run typecheck:edgenpm run test(217 passed),npm run test:edge(44 passed)npm run test:integration:supabase(48 passed). This includes new shame-board assertions in the rage quit test, a new test that a rage quit while behind counts on Biggest Loser, and a test that a player who sets the retired flag still shows on boards.Hall of Shame ranks rage quitters and shows shame on their profile, plus the existing Hall of Suckers test, both on Chromium with axe checks. I didn't run the full browser suite locally.Later
Ideas left out for now: Choked (rage quit while leading), Hair Trigger (earliest rage quit), Crybaby % (quit rate), Cold Streak (longest losing streak), and matching defeat badges.
🤖 Generated with Claude Code