fix(monero-wallet-ng): prefer not_additionally_locked() everywhere - #1195
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 02ee48d. Configure here.
| let funding_output = Scanner::new(bob_view_pair.clone()) | ||
| .scan(daemon.expand_to_scannable_block(funding_block).await?)? | ||
| .ignore_additional_timelock() | ||
| .not_additionally_locked() |
There was a problem hiding this comment.
Coinbase output filtered out
High Severity
Switching the funding coinbase scan to not_additionally_locked() drops the miner output, because coinbase txs still carry a non-None additional timelock (height + 60). The resulting empty vector makes swap_remove(0) panic, so the Hermes happy-path test fails.
Reviewed by Cursor Bugbot for commit 02ee48d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.