Skip to content

wire reward thumbupdown with event bus - #1900

Open
Douglasymlai wants to merge 1 commit into
mainfrom
reward-event-capture
Open

wire reward thumbupdown with event bus#1900
Douglasymlai wants to merge 1 commit into
mainfrom
reward-event-capture

Conversation

@Douglasymlai

@Douglasymlai Douglasymlai commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Related Issue

Closes #

Description

This PR connects the existing message thumbs-up/down controls to the application event bus so user feedback can be consumed by edition-specific analytics adapters.

What changed

  • Adds a typed message_feedback app event containing:
    • rating (up or down)
    • logical message ID
    • Run ID, when available
    • message lifecycle step
  • Propagates Run and message metadata through both narrative and legacy timeline paths.
  • Records at most one rating per Run-scoped message during an app session.
  • Preserves the selected rating when a message card remounts, such as after switching timeline modes.
  • Keeps message content and agent names out of the feedback event.
  • Adds unit coverage for event payloads, logical identity propagation, duplicate prevention, and remount behavior.

Testing Evidence (REQUIRED)

Automated coverage was added for:

  • thumbs-up and thumbs-down event emission
  • logical message and Run identifiers
  • single-rating enforcement
  • feedback persistence across component remounts
  • metadata propagation through narrative and legacy timeline renderers
  • I have included human-verified testing evidence in this PR.
  • This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
  • No frontend/UI changes in this PR.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Contribution Guidelines Acknowledgement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant