fix: restrict ~/.eigent env files to owner-only (0600) - #1895
Open
BetterAndBetterII wants to merge 1 commit into
Open
fix: restrict ~/.eigent env files to owner-only (0600)#1895BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Credential-bearing .env files under ~/.eigent were left at the process umask (often 0644) after Electron writeFileSync updates. Harden creates and loads on POSIX so secrets stay owner-readable. Fixes eigent-ai#1670
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Credential-bearing
.envfiles under~/.eigentwere left at the process umask (often0644) after ElectronwriteFileSyncupdates.getEnvPathonly appliedchmod 0600on the copy-from-default create path, so later writes stayed world-readable.Harden create and load paths on POSIX so secrets stay owner-readable:
~/.eigentenv files / resetting to the default pathwriteEnvFilewrites with mode0600and re-chmods existing files;getEnvPathtightens existing user env filesFixes #1670
Test plan
0644~/.eigentenv files become0600on load/reset; repo-local.envleft alone; chmod failure does not block loadgetEnvPath/writeEnvFileenforce0600on create and update