Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces the herwig3 event generator (v7.3.0) into the XL Spack environment so it’s available in the full EIC container for event generation and Rivet validation workflows.
Changes:
- Add
herwig3to the XL environment spec list (spack-environment/xl/spack.yaml). - Pin
herwig3to version 7.3.0 and disable optional integrations (madgraph5amc,njet,vbfnlo) viaspack-environment/packages.yaml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
spack-environment/xl/spack.yaml |
Adds herwig3 to the XL environment package set. |
spack-environment/packages.yaml |
Defines herwig3 version/variant requirements for concretization. |
veprbl
approved these changes
Jul 17, 2026
Contributor
Author
|
This one (and professor) may not build. I've had trouble with these in spack CI so we'll have to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR adds
herwig3, v7.3.0, so we can use this as part of event generation and rivet validations.What is the urgency of this PR?
What kind of change does this PR introduce?
herwig3-7.3.0)Please check if any of the following apply