Skip to content

Validate upstream workflow starters#17

Merged
ehsanestaji merged 1 commit into
mainfrom
feature/upstream-validation
Jul 3, 2026
Merged

Validate upstream workflow starters#17
ehsanestaji merged 1 commit into
mainfrom
feature/upstream-validation

Conversation

@ehsanestaji

Copy link
Copy Markdown
Owner

Summary

  • Align the nf-core starter with current nf-core module metadata, topic-version output, conda/container conventions, and evidence-preserving exit-code handling.
  • Reshape the Snakemake wrapper starter to upstream layout with root wrapper.py, Linux pin txt, logs, captured exit_code output, and upstream pytest snippet.
  • Document the completed upstream-style validation results and update adoption/readiness next steps.

Validation

  • python3 -m unittest discover -s tests/python
  • cargo test --locked
  • nf-core modules lint fastaguard: 47 passed, 0 warnings, 0 failures
  • nf-core modules test fastaguard --profile conda --once --no-prompts: all tests passed
  • Snakemake upstream checks: black --check, snakefmt --check, snakemake --lint, pytest test_wrappers.py::test_fastaguard

Notes

This keeps FastaGuard positioned as a FASTA preflight layer and prepares external upstream PRs without claiming official nf-core or Snakemake acceptance yet.

@ehsanestaji ehsanestaji marked this pull request as ready for review July 3, 2026 19:37
@ehsanestaji ehsanestaji merged commit 411c5a7 into main Jul 3, 2026
2 checks passed
@ehsanestaji ehsanestaji deleted the feature/upstream-validation branch July 3, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant