fix(detect): add realm-global brand for cross-copy HelpfulError detection#39
Merged
Conversation
…tion - stamp every HelpfulError class with a Symbol.for brand carrying the package version - add isHelpfulError type guard for cross-copy, minification-proof detection - support a version.min gate on isHelpfulError to assert a stamped-version floor - add getHelpfulErrorVersion to read the stamped version off any branded value - brand is static + immutable via Object.defineProperty, so it survives redact and never leaks into toJSON - source version at runtime via direct package.json import, no codegen Co-authored-by: Ulad Kasach <uladkasach@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(detect): add realm-global brand for cross-copy HelpfulError detection
and never leaks into toJSON
🐢🌊 surfed in by seaturtle[bot]