Repository navigation
fix(effect-app): keep xForwardedHeaders error and request types - #928
Merged
Merged
Conversation
Effect 4.0.6 types HttpMiddleware.xForwardedHeaders as HttpMiddleware, so the result is Effect<HttpServerResponse, any, any>. effect-app/http now re-exports that middleware with the app's error and HttpServerRequest requirement preserved. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effect-app/httpre-exportsHttpMiddlewareand replacesxForwardedHeadersso the result keeps the app's error andHttpServerRequestrequirement.HttpMiddleware, which returnsEffect<HttpServerResponse, any, any>. The middleware only updates the current request. Import it fromeffect-app/http;effect/httpis unchanged.Test plan
Effect<HttpServerResponse, never, HttpServerRequest>, and an app with error"Boom"and an extra service keeps both.HttpRouter.middlewarefor the fixed helper matchescors(error: never,requires: never) instead ofany.10.0.0.0/8peer still resolvesX-Forwarded-Forto198.51.100.7.opened by patroza in chat thread Discord · Discord · T3
Need help on this PR? Tag
@codesmith-botwith what you need.