Repository navigation
fix: stop changesets from republishing existing versions - #921
Merged
Merged
Conversation
npm 12 returns `npm info --json` as a one-element array, so changesets never sees the versions list and tries to publish the current package.json versions again. pnpm 12 reports that 403 as ERR_PNPM_FAILED_TO_PUBLISH, which the existing skip did not recognize. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Changesets job on main tried to republish versions that are already on npm, then failed.
npm info <pkg> --jsonfrom npm 12.2.0 (whatnpm@latestinstalls in the release workflow) is a one-element array. Changesets reads.versionson that value, gets nothing, and treats the currentpackage.jsonversion as unpublished.ERR_PNPM_FAILED_TO_PUBLISHandYou cannot publish over the previously published versions. The existing skip only matched npm'sE403.normalizeNpmInfounwraps that array before the versions check. The skip also accepts pnpm's error code. The phrase check already matches the plural wording, becauseversionis a prefix ofversions.No changeset. This patch does not change a published package, and a changeset would open a version PR instead of exercising the "nothing new to publish" path.
Test plan
pnpm install --frozen-lockfile, and a second frozen install leaves the lockfile unchangedeffect-appinfo document unwraps to aversionslist that includes4.0.2ERR_PNPM_FAILED_TO_PUBLISHbody withpreviously published versionsis treated as already publishedpnpm publishfor the current versionsopened by patroza in chat thread Discord · Discord · T3
Need help on this PR? Tag
@codesmith-botwith what you need.