Repository navigation
chore: upgrade to pnpm 12 - #920
Merged
Merged
Conversation
Pin packageManager to pnpm@12.14.0. pnpm 12 rejects a frozen install when a workspace package publishes from .publish but sets linkDirectory to false, so record that in the lockfile. The nix shell fetches the native pnpm 12 binary, and CI installs it with pnpm/action-setup v6.1.0. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
pnpm 12 parses patches with diffy's gitdiff parser, which rejects a unified diff that starts at `---` and reports no valid patches. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade the repo from pnpm 11.18.0 to pnpm 12.14.0.
packageManagertopnpm@12.14.0and requirepnpm >= 12.linkDirectory: falsenext topublishDirectory: .publishin the lockfile. Those workspace packages publish from.publishbut do not link that directory. pnpm 12 treats a missinglinkDirectoryas true and rejectspnpm install --frozen-lockfile.pnpm-lock.yamlfor apackageManagerpin on the 12 line. A frozen install stays stable acrosspnpm installandpnpm list.patches/typescript.patchnow starts with adiff --githeader. pnpm 12 parses patches with diffy's gitdiff parser and rejected the old unified diff (ERR_PNPM_INVALID_PATCH, no valid patches at byte 0). The lockfile patch hash matches the new file.@pnpm/exe.*). nixpkgsgeneric.nixstill linksbin/pnpm.cjs, which pnpm 12 does not ship.pn/pnpx/pnxare hardlinks because the binary dispatches on its filename.pnpm/action-setup@v6.1.0(first release that installs pnpm 12) and a new pnpm store cache key.repos/effectstays on its own pnpm pin. That tree is synced from Effect.Verified locally:
pnpm install --frozen-lockfilewith pnpm 12.14.0 applies the typescript patch on a fresh store entry, andpnpx/pnxfrom the nix shell runpnpm dlx.Test plan
nix developreportspnpm --version12.14.0 on macOS as well as Linuxopened by patroza in chat thread Discord · Discord · T3
Need help on this PR? Tag
@codesmith-botwith what you need.