Skip to content

docs: correct product descriptions in CLMS filenaming guidelines - #77

Merged
mckeea merged 2 commits into
developfrom
docs/filenaming-product-descriptions
Sep 8, 2026
Merged

mckeea merged 2 commits into
developfrom
docs/filenaming-product-descriptions

Conversation

@MatMatt

@MatMatt MatMatt commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Apply Lorenzo's feedback to the CLMS filenaming guidelines:

  • Attribute the IW burst field to the Sentinel-1 swath, not EGMS InSAR (both design-principles and filename-tree)
  • Rephrase the EGMS L3 grid and L2 orbit descriptions to their official labels

validate_qmd_files.py: 36/36 valid.

Apply Lorenzo's feedback:
- Attribute IW burst to Sentinel-1 swath, not EGMS InSAR
- Rephrase EGMS L3 grid and L2 orbit descriptions with their official labels

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7b58417d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

├── L3-U, L3-EW EGMS velocity components (EGMS Ortho – L3)
│
├── L2a-A, L2a-D, L2b-A, L2b-D EGMS calibrated (EGMS L2)
├── L2a-A, L2a-D, L2b-A, L2b-D Orbit (EGMS Calibrated – L2)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Label L2a as Basic rather than Calibrated

Because this branch includes both L2a-A/D and L2b-A/D, describing the entire group as “EGMS Calibrated” misidentifies the L2a variants. The repository's EGMS product description identifies L2a as Basic (DOCS/European_Ground_Motion_Service/Product_Description_v3.qmd:51-61) and L2b as Calibrated (:63-67, :446-448); split the labels or name both product levels here.

Useful? React with 👍 / 👎.

@mckeea mckeea self-assigned this Sep 8, 2026
@mckeea
mckeea self-requested a review September 8, 2026 12:35
@mckeea
mckeea merged commit 5177b73 into develop Sep 8, 2026
3 checks passed
mckeea added a commit that referenced this pull request Oct 2, 2026
* Update LLM cache and version history [skip ci]

* ci: prepare workflows for branch protection rulesets

* ci: pin ruff rule set so upstream default changes don't break CI

* docs: correct required YAML fields and document type in editor guide

* chore: drop editor guide cache entry to force regeneration

* chore: drop one image cache entry to force a cache write

* Update LLM cache and version history [skip ci]

* docs: unify CLMS filenaming doc names and title pattern

Rename both docs to the shared clms-filenaming_<topic>_v1.qmd
pattern, align both titles to 'CLMS Product Filenaming - <Topic>',
and replace em dashes with plain hyphens throughout.

* Update LLM cache and version history [skip ci]

* feat: add parsEO dashboard (filename builder + schema tools)

* fix: use relative API URL, add fetch error handling, debounce, XSS escaping

* fix: empty API base for same-origin (SWAG proxy)

* fix: remove API URL field, auto-connect on same-origin

* feat: clickable chip-tree for filename assembly

* feat: add parsEO dashboard to DOCS/tools (Quarto site)

* feat: add parsEO dashboard to DOCS/tools with index.qmd landing page

* feat: parsEO dashboard as OJS Quarto dashboard (replaces standalone HTML)

* corrected type SFW

* fix: remove bar labels and default to weekly view in CDSE migration dashboard

Remove the +N number labels from the onboarding history bar chart (values are still available via tooltip on hover). Switch the default aggregation mode from daily to weekly for a cleaner overview.

* fix: plot negative onboarding deltas below zero and key weeks by ISO week-year

* fix: make the parsEO dashboard actually run

* Update LLM cache and version history [skip ci]

* Update non-browsable doc map [skip ci]

* docs: use NET-LINE for EU Hydro examples and drop it from the tree (#78)

* docs: correct product descriptions in CLMS filenaming guidelines (#77)

Apply Lorenzo's feedback:
- Attribute IW burst to Sentinel-1 swath, not EGMS InSAR
- Rephrase EGMS L3 grid and L2 orbit descriptions with their official labels

* chore(ci): merge DOCS/clcplus-core from publish-clcplus-core-20260910-094246

Triggered by: CI Workflow
Branch: publish-clcplus-core-20260910-094246
Commit: f658ece
Repo: f658ece

* Update LLM cache and version history [skip ci]

* chore(ci): merge DOCS/clcplus-core from publish-clcplus-core-20260910-095249

Triggered by: CI Workflow
Branch: publish-clcplus-core-20260910-095249
Commit: 382cc06
Repo: 382cc06

* chore(ci): merge DOCS/clcplus-core from publish-clcplus-core-20260910-102206

Triggered by: CI Workflow
Branch: publish-clcplus-core-20260910-102206
Commit: cd1b8ca
Repo: cd1b8ca

* Update LLM cache and version history [skip ci]

* fix(build): realign drifted grid tables and guard dangling links in Typst PDFs

* chore(ci): merge DOCS/clcplus-core from publish-clcplus-core-20260914-100407

Triggered by: CI Workflow
Branch: publish-clcplus-core-20260914-100407
Commit: 1215deb
Repo: 1215deb

* fix(docs): unblock Typst build for CLC+ Core User Manual [skip ci]

* fix(docs): realign drifted grid tables in CLC+ Core User Manual [skip ci]

* fix(preview): apply dangling-link guard to local Typst renders [skip ci]

* feat(build): add BUILD_ONLY filter to build-docs.sh [skip ci]

* docs(agents): require suggestions before implementation [skip ci]

* docs: add Protected Areas 2021/2024 nomenclature and mapping guideline (#79)

* docs: add Protected Areas 2021/2024 nomenclature and mapping guideline

Add the Priority Area Monitoring - Protected Areas 2021 and 2024
Nomenclature and Mapping Guideline, converted from the source PDF.
Includes the full LC/LU class nomenclature and its 377 figures.

`validate_qmd_files.py`: 38/38 valid; all media references resolve.

* docs: restore Table 2 colors and fix fenced-div caption closures

- Restore the LC/LU nomenclature legend colours in Table 2 by sampling each
  code cell's fill from the source PDF (pages 10-11) and injecting it as an
  inline background-color across the three code-level columns (88 cells).
- Close the tbl-caption divs properly (blank line before the closing fence)
  so the caption markers no longer leak into the rendered table text.

* Update LLM cache and version history [skip ci]

* feat(build): compress media at build time, keeping originals in git

* fix(build): compress only document media and repoint references safely

* fix(build): detect transparency portably and flatten onto white

* fix(build): use %[opaque] for transparency, portable across ImageMagick 6 and 7

* chore: sync published version state from main

* chore: hold back unpublished docs (products batch, CDSE and parsEO dashboards)

* chore: remove orphan media and cache of withdrawn HRL SLF PUM draft

* chore: take MRVPP cache entries from main

---------

Co-authored-by: GitHub Actions <actions@github.com>
Co-authored-by: Matteo Mattiuzzi <matteo@mattiuzzi.com>
Co-authored-by: ci_docker_builder <ci_docker_builder@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants