chore: cleaning up jenkins jobs - #379
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The PR title/description describe Jenkins job config cleanup, but the changes shown remove lifecycle/retirement tooling instead, so the PR metadata/scope should be aligned before merge.
Pull request overview
This PR removes legacy AWS autoscaling lifecycle/host-retirement automation artifacts from the configuration repo, likely as part of post-migration cleanup of operational workflows.
Changes:
- Deletes the
asg_lifcycle_watcher.pySQS/ASG lifecycle watcher utility. - Removes the
retire_host.ymlAnsible playbook used for retirement workflows/log sync/minos verification. - Removes the
lifecycle_inventory.pydynamic Ansible inventory script based on ASG instance lifecycle state.
File summaries
| File | Description |
|---|---|
| util/vpc-tools/asg_lifcycle_watcher.py | Removes the ASG lifecycle watcher script that processed SQS lifecycle events. |
| playbooks/retire_host.yml | Removes the Ansible playbook used for host retirement actions and verification steps. |
| playbooks/lifecycle_inventory.py | Removes the dynamic inventory generator that grouped instances by ASG lifecycle state. |
Review details
Suppressed comments (1)
playbooks/retire_host.yml:1
- The PR title/description indicate a Jenkins job config cleanup, but this change deletes a host-retirement playbook (and related lifecycle tooling) rather than updating Jenkins job configuration. Please align the PR title/description with the actual change (decommissioning these retirement tools) or include the intended Jenkins job config changes so reviewers can validate the correct scope.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nkhaleelulla-sonata-byte
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://2u-internal.atlassian.net/browse/GSRE-2681
Summary:
Make sure that the following steps are done before merging: