Skip to content

feature(service): Add Whimsical and Figma services - #123

Merged
neSpecc merged 9 commits into
editor-js:masterfrom
thooams:master
Nov 21, 2025
Merged

feature(service): Add Whimsical and Figma services#123
neSpecc merged 9 commits into
editor-js:masterfrom
thooams:master

Conversation

@thooams

@thooams thooams commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@neSpecc neSpecc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Please, add corresponded tests, increment a patch version and update a service-list in readme

@neSpecc

neSpecc commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

@thooams hey. Are you going to update the PR?

@thooams

thooams commented Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

Yes. I have to find the time to do it

@thooams thooams changed the title feataure(service): Add Whimsical and Figma services feature(service): Add Whimsical and Figma services Apr 23, 2024
@thooams

thooams commented Apr 23, 2024

Copy link
Copy Markdown
Contributor Author

Tests are written.

@neSpecc neSpecc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increment a patch version, please

@neSpecc neSpecc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update a list in Readme, please

@neSpecc

neSpecc commented Oct 12, 2024

Copy link
Copy Markdown
Contributor

Please, update the branch

Comment thread package.json
Comment thread package.json
Comment thread package.json Outdated
Comment thread src/services.ts

@neSpecc neSpecc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, remove all changes unrelated to new services

Comment thread package.json
Comment thread package.json Outdated
Comment thread src/services.ts
Comment thread src/services.ts
@thooams

thooams commented Oct 18, 2024

Copy link
Copy Markdown
Contributor Author

Unexpected changes were removed

@neSpecc
neSpecc merged commit 863834c into editor-js:master Nov 21, 2025
1 check passed
@neSpecc

neSpecc commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

Thanks @thooams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants