Set date/time in StageRuntime instead of Preset#191
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #191 +/- ##
========================================
Coverage 61.99% 61.99%
========================================
Files 303 303
Lines 11663 11663
Branches 1048 1048
========================================
Hits 7231 7231
Misses 4432 4432 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
There are several ways to achieve this result. The appropriate solution should be decided based on tests involving the other affected projects, as I noted in the Teams chat. |
MircoValentiniECMWF
approved these changes
Apr 12, 2026
Contributor
|
Benchmarks confirmed that safe cache is too slow to be taken into consideration as a possible candidate. |
ed76f11 to
bae37af
Compare
dsarmany
approved these changes
Apr 15, 2026
dsarmany
approved these changes
Apr 15, 2026
bae37af to
8bdc834
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mars2grib encoder currently sets date and time once in the preset stage. For climate-dt monthly means will produce increasing date/time. To efficiently reuse previously cached grib2 handles, the date/time must be set in the latest stage (runtime).
Contributor Declaration
By opening this pull request, I affirm the following: