Skip to content

Changes needed for flash attention 4#2181

Draft
clessig wants to merge 2 commits intodevelopfrom
clessig/develop/fa4
Draft

Changes needed for flash attention 4#2181
clessig wants to merge 2 commits intodevelopfrom
clessig/develop/fa4

Conversation

@clessig
Copy link
Copy Markdown
Collaborator

@clessig clessig commented Apr 9, 2026

Description

Changes required for flash attention 4. Install FA4 currently with (for latest varlen support): pip install https://github.com/Dao-AILab/flash-attention/releases/download/fa4-v4.0.0.beta6/flash_attn_4-4.0.0b5-py3-none-any.whl

Issue Number

Closes #2185

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@github-actions github-actions bot added the model Related to model training or definition (not generic infra) label Apr 9, 2026
@github-actions github-actions bot added the performance Work related to performance improvements label Apr 9, 2026
@clessig clessig marked this pull request as draft April 9, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model Related to model training or definition (not generic infra) performance Work related to performance improvements

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Investigate benefits of flash attention 4

1 participant